Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add notification for Glossary Approval Task #14438

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Add notification for Glossary Approval Task #14438

merged 1 commit into from
Dec 19, 2023

Conversation

mohityadav766
Copy link
Contributor

@mohityadav766 mohityadav766 commented Dec 19, 2023 •
edited
Loading

Describe your changes:

Fixes issue with missing bell notification for glossary task to assignees

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@mohityadav766 mohityadav766 added backend safe to test Add this label to run secure Github workflows on PRs labels Dec 19, 2023
@mohityadav766 mohityadav766 self-assigned this Dec 19, 2023
@mohityadav766 mohityadav766 marked this pull request as ready for review December 19, 2023 08:00
@mohityadav766 mohityadav766 requested a review from a team as a code owner December 19, 2023 08:00
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@pmbrull pmbrull merged commit a469d3b into main Dec 19, 2023
28 of 31 checks passed
@pmbrull pmbrull deleted the glossaryApprovalTask branch December 19, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmbrull pmbrull pmbrull approved these changes

@harshach harshach harshach approved these changes

Assignees

@mohityadav766 mohityadav766

Labels
backend safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mohityadav766 @harshach @pmbrull