Fix 13823: Validate and Parse gracefully IngestionPipeline #14461
Conversation
github-actions
bot
added
Ingestion
safe to test
| ingestion_pipeline = IngestionPipeline.parse_obj(config_dict) | ||
| return ingestion_pipeline | ||
|
|
||
| except ValidationError: |
There was a problem hiding this comment.
should we take care of the serviceConnection? Not only the sourceConfig
There was a problem hiding this comment.
I believe that's where we get also a lot of noise, for example when we configure an URI without the scheme or something
There was a problem hiding this comment.
as discussed, that was the wrong comment. We'll be adding it to the run_automations endpoint though
| @@ -400,37 +406,84 @@ def parse_workflow_config_gracefully( | |||
| raise ParsingConfigurationError("Uncaught error when parsing the workflow!") | |||
|
|
|||
|
|
|||
| def parse_test_connection_request_gracefully( | |||
There was a problem hiding this comment.
Removing the method since it wasn't being used anywhere except for tests.
|
|
* fixed ingestion pipeline parsing * Added validation for automation workflow --------- Co-authored-by: Pere Miquel Brull <peremiquelbrull@gmail.com>
Describe your changes:
Fixes #13823
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>