Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #7729 - Add logic to compute passed/failed rows #14472

Merged
merged 25 commits into from
Dec 27, 2023

Conversation

TeddyCr
Copy link
Contributor

@TeddyCr TeddyCr commented Dec 21, 2023

Describe your changes:

Fixes #7729

  • add support for passed/failed rows computation for relevant test cases

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Improvement

  • I have added tests around the new logic.
  • For connector/ingestion changes: I updated the documentation.

@TeddyCr TeddyCr requested review from a team as code owners December 21, 2023 10:15
@github-actions github-actions bot added Ingestion backend safe to test Add this label to run secure Github workflows on PRs labels Dec 21, 2023
Copy link
Contributor

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@TeddyCr TeddyCr changed the title FIXES #7729 - Add logic to compute passed/failed rows Fixes #7729 - Add logic to compute passed/failed rows Dec 21, 2023
Copy link
Contributor

The Java checkstyle failed.

Please run mvn spotless:apply in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
74.4% Coverage on New Code
8.2% Duplication on New Code

See analysis details on SonarCloud

@TeddyCr TeddyCr requested a review from pmbrull December 27, 2023 07:26
@TeddyCr TeddyCr enabled auto-merge (squash) December 27, 2023 11:43
@TeddyCr TeddyCr merged commit 3dc6429 into open-metadata:main Dec 27, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend data quality Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Number of passed/failed rows should be captured
2 participants