Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code clean up related to issues flagged by Sonar and IDE #14491

Merged
merged 1 commit into from
Dec 23, 2023
Merged

Code clean up related to issues flagged by Sonar and IDE #14491

merged 1 commit into from
Dec 23, 2023

Conversation

sureshms
Copy link
Contributor

Describe your changes:

Code clean up related to issues flagged by Sonar and IDE

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@sureshms sureshms requested a review from a team as a code owner December 22, 2023 20:39
@github-actions github-actions bot added backend safe to test Add this label to run secure Github workflows on PRs labels Dec 22, 2023
@github-actions GitHub Actions
Copy link
Contributor

The Java checkstyle failed.

Please run mvn spotless:apply in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@sureshms sureshms force-pushed the codeCleanup.20231222 branch from 503c8bc to 271df5c Compare December 22, 2023 21:07
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sureshms sureshms merged commit 496ae26 into main Dec 23, 2023
@sureshms sureshms deleted the codeCleanup.20231222 branch December 23, 2023 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshach harshach harshach approved these changes

Assignees
No one assigned
Labels
backend safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sureshms @harshach