Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR - generic profiler optimization for sampling and BQ #14507

Merged
merged 11 commits into from
Dec 27, 2023

Conversation

TeddyCr
Copy link
Contributor

@TeddyCr TeddyCr commented Dec 27, 2023

Describe your changes:

  • Fixes High Query Cost using Bigquery TABLE_STORAGE #14433 - we'll keep the current method as a fall back in case table metadata cannot be access from __TABLES__
  • Limit sampling to only the column being profiled (should improve execution and limit cost for columnar database)
  • Default to 1 DAY for BQ partitioned tables

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@TeddyCr TeddyCr requested a review from a team as a code owner December 27, 2023 11:41
@github-actions github-actions bot added Ingestion safe to test Add this label to run secure Github workflows on PRs labels Dec 27, 2023
Copy link
Contributor

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@TeddyCr TeddyCr enabled auto-merge (squash) December 27, 2023 15:40
@TeddyCr TeddyCr requested a review from pmbrull December 27, 2023 17:09
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
29.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@TeddyCr TeddyCr merged commit 61ef552 into open-metadata:main Dec 27, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ingestion profiler safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

High Query Cost using Bigquery TABLE_STORAGE
2 participants