Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#13649 - Add Pipeline Status Skipped #14524

Merged
merged 2 commits into from
Dec 29, 2023
Merged

#13649 - Add Pipeline Status Skipped #14524

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
56a761e
#13649 - Add Pipeline Status Skipped
pmbrull Dec 29, 2023
00dab68
Format
pmbrull Dec 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ingestion/src/metadata/ingestion/source/pipeline/airflow/metadata.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,12 +72,14 @@ class AirflowTaskStatus(Enum):
FAILED = "failed"
QUEUED = "queued"
REMOVED = "removed"
SKIPPED = "skipped"


STATUS_MAP = {
AirflowTaskStatus.SUCCESS.value: StatusType.Successful.value,
AirflowTaskStatus.FAILED.value: StatusType.Failed.value,
AirflowTaskStatus.QUEUED.value: StatusType.Pending.value,
AirflowTaskStatus.SKIPPED.value: StatusType.Skipped.value,
}


Expand Down
5 changes: 4 additions & 1 deletion openmetadata-spec/src/main/resources/json/schema/entity/data/pipeline.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"javaType": "org.openmetadata.schema.type.StatusType",
"description": "Enum defining the possible Status.",
"type": "string",
"enum": ["Successful", "Failed", "Pending"],
"enum": ["Successful", "Failed", "Pending", "Skipped"],
"javaEnums": [
{
"name": "Successful"
Expand All @@ -29,6 +29,9 @@
},
{
"name": "Pending"
},
{
"name": "Skipped"
}
]
},
Expand Down
1 change: 1 addition & 0 deletions openmetadata-ui/src/main/resources/ui/src/assets/svg/skipped-badge.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions openmetadata-ui/src/main/resources/ui/src/constants/execution.constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ export const MenuOptions = {
[StatusType.Successful]: 'Success',
[StatusType.Failed]: 'Failed',
[StatusType.Pending]: 'Pending',
[StatusType.Skipped]: 'Skipped',
Aborted: 'Aborted',
};

Expand Down
3 changes: 3 additions & 0 deletions openmetadata-ui/src/main/resources/ui/src/utils/PipelineDetailsUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,9 @@ export const getStatusBadgeIcon = (status?: StatusType) => {
case StatusType.Pending:
return Icons.PENDING_BADGE;

case StatusType.Skipped:
return Icons.SKIPPED_BADGE;

default:
return '';
}
Expand Down
7 changes: 7 additions & 0 deletions openmetadata-ui/src/main/resources/ui/src/utils/SvgUtils.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,7 @@ import IconSearchV1Color from '../assets/svg/search-color.svg';
import IconSearchV1 from '../assets/svg/search.svg';
import IconSetting from '../assets/svg/service.svg';
import IconShowPassword from '../assets/svg/show-password.svg';
import IconSkippedBadge from '../assets/svg/skipped-badge.svg';
import IconSlackGrey from '../assets/svg/slack-grey.svg';
import IconSlack from '../assets/svg/slack.svg';
import IconSuccessBadge from '../assets/svg/success-badge.svg';
Expand Down Expand Up @@ -338,6 +339,7 @@ export const Icons = {
SUCCESS_BADGE: 'success-badge',
FAIL_BADGE: 'fail-badge',
PENDING_BADGE: 'pending-badge',
SKIPPED_BADGE: 'skipped-badge',
BOT_PROFILE: 'bot-profile',
CREATE_INGESTION: 'create-ingestion',
DEPLOY_INGESTION: 'deploy-ingestion',
Expand Down Expand Up @@ -955,6 +957,11 @@ const SVGIcons: FunctionComponent<Props> = ({ icon, ...props }: Props) => {
case Icons.PENDING_BADGE:
IconComponent = IconPendingBadge;

break;

case Icons.SKIPPED_BADGE:
IconComponent = IconSkippedBadge;

break;
case Icons.BOT_PROFILE:
IconComponent = IconBotProfile;
Expand Down
1 change: 1 addition & 0 deletions openmetadata-ui/src/main/resources/ui/src/utils/executionUtils.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ export const StatusIndicator = ({ status }: StatusIndicatorInterface) => (
: ''}
{status === StatusType.Failed ? MenuOptions[StatusType.Failed] : ''}
{status === StatusType.Pending ? MenuOptions[StatusType.Pending] : ''}
{status === StatusType.Skipped ? MenuOptions[StatusType.Skipped] : ''}
</p>
</Space>
);
Expand Down
Loading