MINOR - Clean topology & add tests #14527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Ingestion
safe to test
pmbrull
commented
Dec 29, 2023
| post_process: the name of the post_process step | ||
| """ | ||
| if post_process == "mark_tables_as_deleted" and not self.context.database: | ||
| raise ValueError("No Database found in `self.context`") |
There was a problem hiding this comment.
this logic should not be here, moved it to the database_service class itself
| @@ -71,72 +67,118 @@ class TopologyRunnerMixin(Generic[C]): | |||
| context: TopologyContext | |||
| metadata: OpenMetadata | |||
|
|
|||
| # The cache will have the shape {`child_stage.type_`: {`name`: `hash`}} | |||
| cache = defaultdict(dict) | |||
There was a problem hiding this comment.
using this cache dict instead of relying on the context to keep things clean
| cache_all: bool = ( | ||
| False # If we need to cache all values being yielded in the context | ||
| # Required fields to define the yielded entity type and the function processing it | ||
| type_: Type[T] = Field( |
There was a problem hiding this comment.
using pydantic descriptions instead of comments
| cache_all=True, | ||
| clear_cache=True, | ||
| store_all_in_context=True, | ||
| clear_context=True, |
There was a problem hiding this comment.
updated names to separate goals from context & cache
ulixius9
approved these changes
Dec 29, 2023
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Fixes
I worked on ... because ...
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>