Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes 14528: skip statuses for tasks that are no longer present in Airflow DAG #14529

Conversation

mgorsk1
Copy link
Contributor

@mgorsk1 mgorsk1 commented Dec 29, 2023

Describe your changes:

Fixes #14528

I worked on filtering out task instances which are related to tasks no longer present in serialized dag object because fetching statuses for such tasks results in errors during ingestion.

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • [] For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@mgorsk1 mgorsk1 requested a review from a team as a code owner December 29, 2023 14:36
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@harshach harshach added the safe to test Add this label to run secure Github workflows on PRs label Dec 30, 2023
harshach
harshach previously approved these changes Dec 30, 2023
@harshach
Copy link
Collaborator

@mgorsk1 thanks for the contribution.

Copy link
Contributor

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@harshach
Copy link
Collaborator

@mgorsk1 can you please fix style check failures, looks like test case is also failing because of the change
image

Copy link
Contributor

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

Copy link
Contributor

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@mgorsk1
Copy link
Contributor Author

mgorsk1 commented Dec 30, 2023

Hey @harshach I've addressed whatever was brought up by CI, should be 👌 now

Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
25.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@harshach harshach merged commit 5ae83b2 into open-metadata:main Dec 30, 2023
@harshach
Copy link
Collaborator

Thanks for your contributions @mgorsk1

@mgorsk1
Copy link
Contributor Author

mgorsk1 commented Dec 31, 2023

sure, always a pleasure 🤝🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Airflow Pipeline Status fails when collecting statuses for tasks no longer present in serialized dag
2 participants