Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR - Fix Empty Test Suites list filter #14546

Merged
merged 2 commits into from
Jan 4, 2024

Conversation

pmbrull
Copy link
Collaborator

@pmbrull pmbrull commented Jan 2, 2024

Describe your changes:

MySQL filter query was not working as expected. Using the same logic with Mysql and postgres now

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@pmbrull pmbrull requested a review from a team as a code owner January 2, 2024 13:34
@pmbrull pmbrull requested a review from TeddyCr January 2, 2024 13:34
@github-actions github-actions bot added backend Ingestion safe to test Add this label to run secure Github workflows on PRs labels Jan 2, 2024
@github-actions github-actions bot added the UI UI specific issues label Jan 2, 2024
Copy link
Contributor

github-actions bot commented Jan 2, 2024

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 49%
50.09% (25089/50089) 32.87% (9901/30125) 31.38% (2863/9125)

Copy link

sonarqubecloud bot commented Jan 4, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarqubecloud bot commented Jan 4, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

cypress bot commented Jan 4, 2024

10 failed tests on run #32799 ↗︎

10 486 8 0 Flakiness 0

Details:

allowed empty test suite to appear in logical test suite page
Project: openmetadata Commit: 4daef967bd
Status: Failed Duration: 38:49 💡
Started: Jan 4, 2024 10:25 AM Ended: Jan 4, 2024 11:04 AM
Failed  Service/postgres.spec.js • 2 failed tests • cypress-ci-mysql-oss-7408122476-1

View Output Video

Test Artifacts
Postgres Ingestion > Update table description and verify description after re-run Screenshots Video
Postgres Ingestion > Verify if usage is ingested properly Screenshots Video
Failed  Pages/ServiceVersionPage.spec.js • 1 failed test • cypress-ci-mysql-oss-7408122476-1

View Output Video

Test Artifacts
Common prerequisite for service version test > Search service version page > Search version page should show version details after soft deleted Screenshots Video
Failed  Flow/AddAndRemoveTierAndOwner.spec.js • 1 failed test • cypress-ci-mysql-oss-7408122476-1

View Output Video

Test Artifacts
Add and Remove Owner > GlossaryTerm details page Screenshots Video
Failed  Service/superset.spec.js • 1 failed test • cypress-ci-mysql-oss-7408122476-1

View Output Video

Test Artifacts
Superset Ingestion > Update table description and verify description after re-run Screenshots Video
Failed  Service/mysql.spec.js • 1 failed test • cypress-ci-mysql-oss-7408122476-1

View Output Video

Test Artifacts
MySQL Ingestion > Update table description and verify description after re-run Screenshots Video

The first 5 failed specs are shown, see all 8 specs in Cypress Cloud.

Review all test suite changes for PR #14546 ↗︎

@chirag-madlani chirag-madlani merged commit d16980a into open-metadata:main Jan 4, 2024
34 of 44 checks passed
@pmbrull pmbrull deleted the test-suite-empty-fix branch January 4, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend e2e This will trigger e2e test workflows Ingestion safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants