New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(#14539): make the input font-color consistent #14551

Merged

chirag-madlani merged 8 commits into open-metadata:main from Abhishek332:issue-14539

Jan 4, 2024

Contributor

Abhishek332 commented Jan 3, 2024 •

edited

Loading

### Before fix

### After fix


          fix(open-metadata#14539): make the input font-color consistent

3ab267b

Abhishek332 requested review from harshach, karanh37 and chirag-madlani as code owners

January 3, 2024 05:57

github-actions bot added the UI label

Contributor

github-actions bot commented Jan 3, 2024

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

karanh37 reviewed

View reviewed changes

openmetadata-ui/src/main/resources/ui/src/styles/app.less Outdated Show resolved Hide resolved

Abhishek332 added 2 commits

January 3, 2024 12:37


          Revert "fix(open-metadata#14539): make the input font-color consistent"

307a575

This reverts commit 3ab267b.


          address comments

547daf0

Contributor

github-actions bot commented Jan 3, 2024

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

Abhishek332 marked this pull request as draft

January 3, 2024 08:08


          Revert "address comments"

371cc99

This reverts commit 547daf0.

Contributor

github-actions bot commented Jan 3, 2024

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!


          update input color by updating variable of default theme

506f0f0

Contributor

github-actions bot commented Jan 3, 2024

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

Abhishek332 marked this pull request as ready for review

January 3, 2024 08:19


          change rjsf input-field color to #292929 from #757575 to make consist…

8e5d92b

…ant color everywhere

Contributor

github-actions bot commented Jan 3, 2024

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!


          Merge branch 'main' into issue-14539

f746bb4

Contributor

github-actions bot commented Jan 3, 2024

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!


          Merge branch 'main' into issue-14539

0b31283

Contributor

github-actions bot commented Jan 3, 2024

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

karanh37 added the safe to test label

karanh37 approved these changes

View reviewed changes

Contributor

github-actions bot commented Jan 3, 2024

Jest test Coverage

UI tests summary

Lines	Statements	Branches	Functions
	50.24% (25173/50108)	32.99% (9943/30135)	31.53% (2877/9126)

sonarqubecloud bot commented Jan 3, 2024

Quality Gate passed for 'open-metadata-ui'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Collaborator

harshach commented Jan 3, 2024

we should provide a link to here https://docs.open-metadata.org/v1.2.x/deployment/ingestion/openmetadata#troubleshooting

chirag-madlani merged commit 26e9af9 into open-metadata:main

Collaborator

chirag-madlani commented Jan 4, 2024

@Abhishek332 can you add a link for Airflow troubleshooting to your next PR? Thanks

karanh37 mentioned this pull request

Use consistent font colours in service connection form #14539

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test UI