Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#14486 : fix current user appearing while editing task assignees #14557

Merged
merged 4 commits into from
Jan 3, 2024

Conversation

Ashish8689
Copy link
Contributor

Describe your changes:

Fixes #14486

  • I worked on fixing current user appearing while editing task assignees
Screen.Recording.2024-01-03.at.2.30.11.PM.mov

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Ashish8689 Ashish8689 added the UI UI specific issues label Jan 3, 2024
@Ashish8689 Ashish8689 self-assigned this Jan 3, 2024
@github-actions github-actions bot added the safe to test Add this label to run secure Github workflows on PRs label Jan 3, 2024
Copy link
Contributor

github-actions bot commented Jan 3, 2024

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 49%
50.17% (25128/50089) 32.93% (9919/30121) 31.49% (2873/9124)

@Ashish8689 Ashish8689 marked this pull request as ready for review January 3, 2024 10:56
Copy link

sonarqubecloud bot commented Jan 3, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Ashish8689 Ashish8689 merged commit a0d8513 into main Jan 3, 2024
16 checks passed
@Ashish8689 Ashish8689 deleted the current-reviewier-task branch January 3, 2024 12:05
Ashish8689 added a commit that referenced this pull request Jan 3, 2024
)

* fix current user appering while editing task assignees

* added unit test to filter current user

* minor changes

(cherry picked from commit a0d8513)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disallow changing reviewers when creating a term
2 participants