fix #7729 Number of passed/failed rows should be captured #14568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaileshParmar11
requested review from
harshach,
karanh37 and
chirag-madlani
as code owners
github-actions
bot
added
the
safe to test
Jest test CoverageUI tests summary
|
openmetadata-ui/src/main/resources/ui/src/components/AddDataQualityTest/EditTestCaseModal.tsx
Show resolved
Hide resolved
openmetadata-ui/src/main/resources/ui/src/components/AddDataQualityTest/EditTestCaseModal.tsx
Outdated
Show resolved
Hide resolved
...adata-ui/src/main/resources/ui/src/components/AddDataQualityTest/components/TestCaseForm.tsx
Show resolved
Hide resolved
...-ui/src/main/resources/ui/src/components/Persona/AddEditPersona/AddEditPersona.component.tsx
Show resolved
Hide resolved
...metadata-ui/src/main/resources/ui/src/components/ProfilerDashboard/component/TestSummary.tsx
Outdated
Show resolved
Hide resolved
...sources/ui/src/components/ProfilerDashboard/component/TestSummaryCustomTooltip.component.tsx
Outdated
Show resolved
Hide resolved
Sachin-chaurasiya
approved these changes
Jan 5, 2024
|
karanh37
approved these changes
Jan 5, 2024
Comment on lines
+33
to
+46
| <ul data-testid="test-summary-tool-tip-container"> | ||
| {data.map(([key, value]) => ( | ||
| <li | ||
| className="d-flex items-center justify-between gap-6 p-b-xss text-sm" | ||
| key={`item-${key}`}> | ||
| <span className="flex items-center text-grey-muted"> | ||
| {startCase(key)} | ||
| </span> | ||
| <span className="font-medium" data-testid={key}> | ||
| {value} | ||
| </span> | ||
| </li> | ||
| ))} | ||
| </ul> |
There was a problem hiding this comment.
Can we use AntD list here?
There was a problem hiding this comment.
Will check for that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Fixes #7729
I worked on ... because ...
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>