Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: activity feed card header alignment #14580

Merged
merged 26 commits into from
Jan 12, 2024
Merged

fix: activity feed card header alignment #14580

merged 26 commits into from
Jan 12, 2024

Conversation

Abhishek332
Copy link
Contributor

@Abhishek332 Abhishek332 commented Jan 4, 2024 •
edited
Loading

### Before Fix
Screenshot 2024-01-04 at 8 20 08 PM

Screenshot 2024-01-09 at 10 16 20 PM

### After Fix
Screenshot 2024-01-05 at 3 11 10 PM

Screenshot 2024-01-09 at 10 16 50 PM

@github-actions github-actions bot added the UI UI specific issues label Jan 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 4, 2024

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 4, 2024

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@Sachin-chaurasiya Sachin-chaurasiya added the safe to test Add this label to run secure Github workflows on PRs label Jan 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 4, 2024 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 52%
 52.51% (26575/50611) 34.41% (10442/30347) 33.47% (3096/9251)

@chirag-madlani
Copy link
Collaborator

@Abhishek332 can we not break sentances?
Can we have Admin posted posted on a table • to be on a single line and if needed wrap it?

@Abhishek332 Abhishek332 marked this pull request as draft January 5, 2024 06:29
@Abhishek332 Abhishek332 marked this pull request as ready for review January 5, 2024 09:31
@Abhishek332
Copy link
Contributor Author

Abhishek332 commented Jan 5, 2024 •
edited
Loading

@Abhishek332 can we not break sentances? Can we have Admin posted posted on a table • to be on a single line and if needed wrap it?

@chirag-madlani Done

@chirag-madlani chirag-madlani added the e2e This will trigger e2e test workflows label Jan 5, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@chirag-madlani chirag-madlani merged commit 156dc29 into open-metadata:main Jan 12, 2024
@Abhishek332 Abhishek332 deleted the feed-card-header-alignment branch January 15, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@karanh37 karanh37 karanh37 left review comments

@harshach harshach Awaiting requested review from harshach

Assignees

@Abhishek332 Abhishek332

Labels
e2e This will trigger e2e test workflows safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Abhishek332 @chirag-madlani @karanh37 @Sachin-chaurasiya