Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rendering of more complex pipelines tree view #14595

Conversation

mgorsk1
Copy link
Contributor

@mgorsk1 mgorsk1 commented Jan 5, 2024

Describe your changes:

Fixes 14599

I worked on fixing executionUtils getTreeData method because it's current implementation is not suitable for precise depicting parent > child relationships between pipeline tasks in Tree view of Executions tab.

Before (notice lack of process_task_X in Tree view of Executions tab)

Nagranie.z.ekranu.2024-01-5.o.17.47.23.mov

After:

Nagranie.z.ekranu.2024-01-5.o.18.01.13.mov

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added the UI UI specific issues label Jan 5, 2024
Copy link
Contributor

github-actions bot commented Jan 5, 2024

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

Copy link
Contributor

github-actions bot commented Jan 5, 2024

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@mgorsk1 mgorsk1 marked this pull request as ready for review January 5, 2024 17:04
Copy link
Contributor

github-actions bot commented Jan 5, 2024

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@harshach harshach added the safe to test Add this label to run secure Github workflows on PRs label Jan 5, 2024
@harshach
Copy link
Collaborator

harshach commented Jan 5, 2024

hi @mgorsk1 Thanks for the PR. We will review and merge it in
cc @chirag-madlani

@harshach
Copy link
Collaborator

harshach commented Jan 5, 2024

@ShaileshParmar11 did your DAG changes for this merged in? can you work with @mgorsk1 to get this PR in.

Copy link
Contributor

github-actions bot commented Jan 5, 2024

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 51%
51.52% (25835/50144) 33.75% (10165/30120) 32.5% (2969/9134)

@ShaileshParmar11
Copy link
Contributor

Yes my UI changes merged! @harshach

Copy link

sonarqubecloud bot commented Jan 5, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@mgorsk1
Copy link
Contributor Author

mgorsk1 commented Jan 6, 2024

so are we happy about this PR @ShaileshParmar11? I have fixed all the linting issues and ci seems to be satisfied.

@chirag-madlani chirag-madlani merged commit 83a1d4b into open-metadata:main Jan 6, 2024
@chirag-madlani
Copy link
Collaborator

Thank you @mgorsk1

@mgorsk1
Copy link
Contributor Author

mgorsk1 commented Jan 6, 2024

🤝🏼

@mgorsk1 mgorsk1 deleted the fix/rendering-of-more-complex-pipelines-tree-view branch January 6, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tree tasks view in execution tab is not rendered properly for pipeline statuses
4 participants