Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #14610: includeEmptyTestSuite behavior causing not include newly created test suites #14611

Merged
merged 4 commits into from
Jan 9, 2024

Conversation

harshach
Copy link
Collaborator

@harshach harshach commented Jan 7, 2024

Describe your changes:

Fixes #14610

  • User creates a test case for the first time on a table, UI makes call to create a native testSuite and also creates the test case for it. This test suite must show up in DQ page.
  • User deletes the last test case belonging to a native test suite. This test suite has zero tests and shouldn't be visible in DQ page.
  • Added new status called "Queued" to the TestCaseStatus to indicate a newly created test case is yet to run @ShaileshParmar11 we need to display this in the DQ page as another metric after Aborted.

@TeddyCr give it a review please.

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@harshach harshach requested a review from TeddyCr January 7, 2024 22:34
@harshach harshach requested a review from a team as a code owner January 7, 2024 22:34
@github-actions github-actions bot added backend safe to test Add this label to run secure Github workflows on PRs labels Jan 7, 2024
pmbrull
pmbrull previously approved these changes Jan 8, 2024
Copy link

sonarqubecloud bot commented Jan 9, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@harshach harshach merged commit 8f37d7d into main Jan 9, 2024
@harshach harshach deleted the issue-14610 branch January 9, 2024 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

includeEmptyTestSuite behavior causing not include newly created test suites
2 participants