Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump follow-redirects from 1.15.3 to 1.15.4 in /openmetadata-ui/src/main/resources/ui #14644

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 9, 2024

Bumps follow-redirects from 1.15.3 to 1.15.4.

Commits
  • 6585820 Release version 1.15.4 of the npm package.
  • 7a6567e Disallow bracketed hostnames.
  • 05629af Prefer native URL instead of deprecated url.parse.
  • 1cba8e8 Prefer native URL instead of legacy url.resolve.
  • 72bc2a4 Simplify _processResponse error handling.
  • 3d42aec Add bracket tests.
  • bcbb096 Do not directly set Error properties.
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.3 to 1.15.4.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](follow-redirects/follow-redirects@v1.15.3...v1.15.4)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Jan 9, 2024
@github-actions github-actions bot added the UI UI specific issues label Jan 9, 2024
Copy link
Contributor

github-actions bot commented Jan 9, 2024

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@chirag-madlani chirag-madlani added the safe to test Add this label to run secure Github workflows on PRs label Jan 11, 2024
Copy link
Contributor

github-actions bot commented Jan 11, 2024

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 52%
52.82% (26714/50574) 34.66% (10505/30312) 33.73% (3114/9231)

@harshach
Copy link
Collaborator

@chirag-madlani or @karanh37 can we merge this?

@chirag-madlani
Copy link
Collaborator

@harshach Yes, let me take care of this today only

Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

cypress bot commented Jan 16, 2024

51 failed tests on run #32962 ↗︎

51 482 39 120 Flakiness 0

Details:

Merge branch 'main' into dependabot/npm_and_yarn/openmetadata-ui/src/main/resour...
Project: openmetadata Commit: 69b9b89c29
Status: Failed Duration: 29:47 💡
Started: Jan 16, 2024 5:45 AM Ended: Jan 16, 2024 6:15 AM
Failed  Pages/Services.spec.ts • 10 failed tests • cypress-ci-psql-oss-7537428636-1

View Output Video

Test Artifacts
Messaging Service page > Hard delete Screenshots Video
Dashboard Service page > Domain assign, update & delete Screenshots Video
Pipeline Service page > Domain assign, update & delete Screenshots Video
Pipeline Service page > Hard delete Screenshots Video
MlModel Service page > Domain assign, update & delete Screenshots Video
MlModel Service page > Hard delete Screenshots Video
Storage Service page > Domain assign, update & delete Screenshots Video
Storage Service page > Hard delete Screenshots Video
Search Service page > Domain assign, update & delete Screenshots Video
Search Service page > Hard delete Screenshots Video
Failed  Pages/Database.spec.ts • 7 failed tests • cypress-ci-psql-oss-7537428636-1

View Output Video

Test Artifacts
Database page > Domain assign, update & delete Screenshots Video
Database Schema page > Domain assign, update & delete Screenshots Video
Database Schema page > Hard delete Screenshots Video
Store Procedure page > Domain assign, update & delete Screenshots Video
Store Procedure page > Hard delete Screenshots Video
Table page > Domain assign, update & delete Screenshots Video
Table page > Hard delete Screenshots Video
Failed  Pages/Users.spec.ts • 1 failed test • cypress-ci-psql-oss-7537428636-1

View Output Video

Test Artifacts
User with different Roles > Check Data Steward permissions Screenshots Video
Failed  Service/postgres.spec.js • 1 failed test • cypress-ci-psql-oss-7537428636-1

View Output Video

Test Artifacts
Postgres Ingestion > Verify if usage is ingested properly Screenshots Video
Failed  Features/Following.spec.js • 14 failed tests • cypress-ci-psql-oss-7537428636-1

View Output Video

Test Artifacts
Following data assets > following section should have cy-table-574060 followed Screenshots Video
Following data assets > following section should have cypress-dashboard-353972 followed Screenshots Video
Following data assets > following section should have cypress-topic-500860 followed Screenshots Video
Following data assets > following section should have cypress-pipeline-652621 followed Screenshots Video
Following data assets > following section should have cypress-mlmodel-56816 followed Screenshots Video
Following data assets > following section should have cy-stored-procedure-657413 followed Screenshots Video
Following data assets > following section should have cypress-dashboard-649494 followed Screenshots Video
Following data assets > unfollowing entity cy-table-574060 should removed from following section Screenshots Video
Following data assets > unfollowing entity cypress-dashboard-353972 should removed from following section Screenshots Video
Following data assets > unfollowing entity cypress-topic-500860 should removed from following section Screenshots Video
The first 10 failed tests are shown, see all 14 tests in Cypress Cloud.

The first 5 failed specs are shown, see all 12 specs in Cypress Cloud.

Review all test suite changes for PR #14644 ↗︎

@chirag-madlani chirag-madlani merged commit be70403 into main Jan 19, 2024
18 of 28 checks passed
@chirag-madlani chirag-madlani deleted the dependabot/npm_and_yarn/openmetadata-ui/src/main/resources/ui/follow-redirects-1.15.4 branch January 19, 2024 16:44
Abhishek332 pushed a commit to Abhishek332/OpenMetadata that referenced this pull request Jan 25, 2024
…-metadata#14644)

Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.3 to 1.15.4.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](follow-redirects/follow-redirects@v1.15.3...v1.15.4)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Chirag Madlani <12962843+chirag-madlani@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file e2e This will trigger e2e test workflows javascript Pull requests that update Javascript code safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants