Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): organise ingestion tests #14649

Merged
merged 25 commits into from
Jan 16, 2024
Merged

test(e2e): organise ingestion tests #14649

merged 25 commits into from
Jan 16, 2024

Conversation

chirag-madlani
Copy link
Collaborator

Describe your changes:

Fixes

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added UI UI specific issues safe to test Add this label to run secure Github workflows on PRs labels Jan 9, 2024
Copy link
Contributor

github-actions bot commented Jan 9, 2024

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 52%
53.12% (26954/50744) 35.3% (10748/30444) 33.98% (3151/9274)

@chirag-madlani chirag-madlani added the e2e This will trigger e2e test workflows label Jan 9, 2024
Copy link

cypress bot commented Jan 9, 2024

35 failed tests on run #32967 ↗︎

35 525 37 89 Flakiness 0

Details:

Merge branch 'main' into organise-service-test
Project: openmetadata Commit: 62c8a36990
Status: Failed Duration: 34:58 💡
Started: Jan 16, 2024 10:04 AM Ended: Jan 16, 2024 10:39 AM
Failed  Entity.spec.ts • 5 failed tests • cypress-ci-psql-oss-7539762358-1

View Output Video

Test Artifacts
Container page > Domain assign, update & delete Screenshots Video
SearchIndex page > Domain assign, update & delete Screenshots Video
SearchIndex page > Hard delete Screenshots Video
Dashboard Data Model page > Domain assign, update & delete Screenshots Video
Dashboard Data Model page > Hard delete Screenshots Video
Failed  Services.spec.ts • 1 failed test • cypress-ci-psql-oss-7539762358-1

View Output Video

Test Artifacts
Search Service page > Domain assign, update & delete Screenshots Video
Failed  Glossary.spec.js • 3 failed tests • cypress-ci-psql-oss-7539762358-1

View Output Video

Test Artifacts
Glossary page should work properly > Add asset to glossary term using asset modal Screenshots Video
Glossary page should work properly > Remove asset from glossary term using asset modal Screenshots Video
Glossary page should work properly > Tags and entity summary columns should be sorted based on current Term Page Screenshots Video
Failed  Database.spec.ts • 3 failed tests • cypress-ci-psql-oss-7539762358-1

View Output Video

Test Artifacts
Store Procedure page > Domain assign, update & delete Screenshots Video
Table page > Domain assign, update & delete Screenshots Video
Table page > Hard delete Screenshots Video
Failed  EntityVersionPages.spec.js • 4 failed tests • cypress-ci-psql-oss-7539762358-1

View Output Video

Test Artifacts
Version page tests for data assets > Stored Procedure version page should work properly > Stored Procedure version page should show description, tag and child field name changes properly Screenshots Video
Version page tests for data assets > Stored Procedure version page should work properly > Stored Procedure version page should show owner changes properly Screenshots Video
Version page tests for data assets > Stored Procedure version page should work properly > Stored Procedure version page should show tier changes properly Screenshots Video
Version page tests for data assets > Stored Procedure version page should work properly > Stored Procedure version page should show changes after soft deleted Screenshots Video

The first 5 failed specs are shown, see all 11 specs in Cypress Cloud.

Review all test suite changes for PR #14649 ↗︎

@chirag-madlani chirag-madlani marked this pull request as draft January 11, 2024 05:11
@chirag-madlani chirag-madlani changed the title test(e2e): organise ingestion tests [WIP] test(e2e): organise ingestion tests Jan 11, 2024
@chirag-madlani chirag-madlani marked this pull request as ready for review January 11, 2024 13:49
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@chirag-madlani chirag-madlani changed the title [WIP] test(e2e): organise ingestion tests test(e2e): organise ingestion tests Jan 16, 2024
@chirag-madlani chirag-madlani merged commit ae884d5 into main Jan 16, 2024
14 of 18 checks passed
@chirag-madlani chirag-madlani deleted the organise-service-test branch January 16, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e This will trigger e2e test workflows safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants