Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Database and Schema on Explore Menu #14656

Merged
merged 12 commits into from
Jan 15, 2024
Merged

Conversation

karanh37
Copy link
Contributor

@karanh37 karanh37 commented Jan 9, 2024

Describe your changes:

Fixes #13276

I worked on ... because ...

image

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@karanh37 karanh37 marked this pull request as draft January 9, 2024 14:29
@github-actions github-actions bot added UI UI specific issues safe to test Add this label to run secure Github workflows on PRs labels Jan 9, 2024
Copy link
Contributor

github-actions bot commented Jan 9, 2024

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 52%
52.8% (26681/50536) 34.62% (10490/30304) 33.7% (3110/9229)

@mgorsk1
Copy link
Contributor

mgorsk1 commented Jan 11, 2024

This is great and very needed but explore list is becoming more and more chaotically ordered - it's neither alphabetical nor ordered by amount of matching documents. What is the rationale behind placing elements in Explore list? I think it would use some UX refinement:

  • Database, Schema and Table entries should be grouped into one Database Service group and ordered according to hierarchy
  • Other entries should be ordered alphabetically
  • Since Explore lists assets in plural form, we should have Database Schemas instead of Database Schema

cc @harshach do you maybe have some UX design/research to help with making this list more coherent?

@harshach
Copy link
Collaborator

@mgorsk1 thanks for your input. Yes we do have UX designers :) , we are working several different options and none of them are to our satisfaction currently. The goal is to ship the functionality and improve the design here. Will see what we can do.

@mgorsk1
Copy link
Contributor

mgorsk1 commented Jan 11, 2024

cool, very glad it's happening anyways @harshach 😍

Copy link

cypress bot commented Jan 11, 2024

35 failed tests on run #32951 ↗︎

35 550 39 64 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge branch 'main' into explore-database-add
Project: openmetadata Commit: 0c48d66a8d
Status: Failed Duration: 50:51 💡
Started: Jan 15, 2024 5:44 AM Ended: Jan 15, 2024 7:34 AM

Review all test suite changes for PR #14656 ↗︎

@chirag-madlani
Copy link
Collaborator

@harshach can you review as well?

Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@chirag-madlani chirag-madlani merged commit c87b6d6 into main Jan 15, 2024
16 of 17 checks passed
@chirag-madlani chirag-madlani deleted the explore-database-add branch January 15, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e This will trigger e2e test workflows safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search on database schemas
4 participants