Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skip(test): cypress tests which are failing #14659

Merged
merged 12 commits into from
Jan 11, 2024
Merged

skip(test): cypress tests which are failing #14659

merged 12 commits into from
Jan 11, 2024

Conversation

chirag-madlani
Copy link
Collaborator

@chirag-madlani chirag-madlani commented Jan 9, 2024 •
edited
Loading

Describe your changes:

Fixes

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added UI UI specific issues safe to test Add this label to run secure Github workflows on PRs labels Jan 9, 2024
@chirag-madlani chirag-madlani added the e2e This will trigger e2e test workflows label Jan 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2024 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 52%
 52.53% (26630/50696) 34.59% (10462/30249) 33.51% (3101/9254)

@cypress Cypress
Copy link

cypress bot commented Jan 9, 2024 •
edited
Loading

3 failed tests on run #32895 ↗︎

3 640 45 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

fix test
Project: openmetadata Commit: beb8bf56e8
Status: Failed Duration: 00:09 💡
Started: Jan 10, 2024 5:11 PM Ended: Jan 10, 2024 7:12 PM

Review all test suite changes for PR #14659 ↗︎

@chirag-madlani chirag-madlani marked this pull request as draft January 10, 2024 06:09
@chirag-madlani chirag-madlani marked this pull request as ready for review January 10, 2024 11:51
@chirag-madlani chirag-madlani removed the e2e This will trigger e2e test workflows label Jan 10, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@chirag-madlani chirag-madlani merged commit 6118353 into main Jan 11, 2024
20 of 24 checks passed
@chirag-madlani chirag-madlani deleted the skip-ingestion branch January 11, 2024 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaileshParmar11 ShaileshParmar11 ShaileshParmar11 approved these changes

@harshach harshach Awaiting requested review from harshach

@karanh37 karanh37 Awaiting requested review from karanh37

Assignees
No one assigned
Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chirag-madlani @ShaileshParmar11 @karanh37