Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: remove deprecated getURLWithQueryFields util method #14671

Merged
merged 12 commits into from
Jan 12, 2024
Merged

Minor: remove deprecated getURLWithQueryFields util method #14671

merged 12 commits into from
Jan 12, 2024

Conversation

Sachin-chaurasiya
Copy link
Contributor

@Sachin-chaurasiya Sachin-chaurasiya commented Jan 10, 2024 •
edited
Loading

Describe your changes:

Fixes

I worked on removing the getURLWithQueryFields util method as it is deprecated and we are using params directly for API requests.

Type of change:

  • Improvement

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Sachin-chaurasiya Sachin-chaurasiya self-assigned this Jan 10, 2024
@github-actions github-actions bot added UI UI specific issues safe to test Add this label to run secure Github workflows on PRs labels Jan 10, 2024
@Sachin-chaurasiya Sachin-chaurasiya added the e2e This will trigger e2e test workflows label Jan 10, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

The SonarCloud Quality Gate passed, but some issues were introduced.

3 New issues
0 Security Hotspots
0.0% Coverage on New Code
1.2% Duplication on New Code

See analysis details on SonarCloud

@Sachin-chaurasiya Sachin-chaurasiya changed the title [WIP] Minor: remove deprecated getURLWithQueryFields util method Minor: remove deprecated getURLWithQueryFields util method Jan 12, 2024
@Sachin-chaurasiya Sachin-chaurasiya merged commit dcbd6a8 into main Jan 12, 2024
@Sachin-chaurasiya Sachin-chaurasiya deleted the remove-getURLWithQueryFields branch January 12, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@harshach harshach Awaiting requested review from harshach

@karanh37 karanh37 Awaiting requested review from karanh37

Assignees

@Sachin-chaurasiya Sachin-chaurasiya

Labels
e2e This will trigger e2e test workflows safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sachin-chaurasiya @chirag-madlani