Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: Add glossary index to SearchIndexFactory #14690

Merged
merged 2 commits into from
Jan 12, 2024
Merged

Minor: Add glossary index to SearchIndexFactory #14690

merged 2 commits into from
Jan 12, 2024

Conversation

harshach
Copy link
Collaborator

Describe your changes:

Fixes

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@harshach harshach requested a review from a team as a code owner January 11, 2024 19:35
@github-actions github-actions bot added backend safe to test Add this label to run secure Github workflows on PRs labels Jan 11, 2024
mohityadav766
mohityadav766 reviewed Jan 11, 2024
View reviewed changes
openmetadata-service/src/main/java/org/openmetadata/service/search/SearchIndexFactory.java Outdated
@@ -82,6 +83,7 @@ public SearchIndex buildIndex(String entityType, Object entity) {
case Entity.PIPELINE -> new PipelineIndex((Pipeline) entity);
case Entity.USER -> new UserIndex((User) entity);
case Entity.TEAM -> new TeamIndex((Team) entity);
case Entity.GLOSSARY -> new GlossaryIndex((GlossaryTerm) entity);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we please confirm if this casting won;t fail, and the entity is actually GlossaryTerm and not Glossary

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yikes!!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mohityadav766 pushed a fix. PTAL

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@harshach harshach merged commit e786380 into main Jan 12, 2024
16 checks passed
@harshach harshach deleted the fix_search_index branch January 12, 2024 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohityadav766 mohityadav766 mohityadav766 approved these changes

Assignees
No one assigned
Labels
backend safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harshach @mohityadav766