Fix #14578: Fixed mode test connection #14693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Ingestion
backend
safe to test
OnkarVO7
commented
Jan 12, 2024
| workspace_name=workspace_name, | ||
| collection_token=collection.get(TOKEN), | ||
| ) | ||
| all_reports = [] |
There was a problem hiding this comment.
removing the try/except here since this is the initial step and we don't want to move forward in the ingestion if this step fails
OnkarVO7
commented
Jan 12, 2024
| @@ -180,11 +175,3 @@ def get_all_data_sources(self, workspace_name: str) -> Optional[dict]: | |||
| logger.warning(f"Error fetching all data sources: {exc}") | |||
|
|
|||
| return None | |||
|
|
|||
| def get_user_account(self) -> dict: | |||
There was a problem hiding this comment.
The method was only being used for test connection and not in actual ingestion. Changed the test connection to actually test getting the dashboards now.
Also this /account endpoint is not supported for the workspace tokens as pointed out in the mode docs
|
ulixius9
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Fixes #14578
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>