Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #14694: Search - Change default operator to OR instead of AND #14695

Merged
merged 5 commits into from
Jan 16, 2024
Merged

Fix #14694: Search - Change default operator to OR instead of AND #14695

merged 5 commits into from
Jan 16, 2024

Conversation

harshach
Copy link
Collaborator

Describe your changes:

Fixes

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@harshach harshach requested a review from a team as a code owner January 12, 2024 07:32
@github-actions github-actions bot added backend safe to test Add this label to run secure Github workflows on PRs labels Jan 12, 2024
chirag-madlani
chirag-madlani previously approved these changes Jan 12, 2024
View reviewed changes
@harshach harshach added the e2e This will trigger e2e test workflows label Jan 15, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Please retry analysis of this Pull-Request directly on SonarCloud

@cypress Cypress
Copy link

cypress bot commented Jan 15, 2024 •
edited
Loading

39 failed tests on run #32961 ↗︎

39 547 39 63 Flakiness 0

Details:

Tune weights on the search fields
Project: openmetadata Commit: 276083ed57
Status: Failed Duration: 00:09 💡
Started: Jan 15, 2024 10:55 PM Ended: Jan 16, 2024 12:56 AM
Failed  Pages/Services.spec.ts • 1 failed test • cypress-ci-psql-oss-7534660178-1

View Output Video

Test Artifacts
Search Service page > Domain assign, update & delete Screenshots Video
Failed  Pages/Database.spec.ts • 7 failed tests • cypress-ci-psql-oss-7534660178-1

View Output Video

Test Artifacts
Database page > Soft delete Screenshots Video
Database page > Hard delete Screenshots Video
Database Schema page > Domain assign, update & delete Screenshots Video
Store Procedure page > Domain assign, update & delete Screenshots Video
Store Procedure page > Hard delete Screenshots Video
Table page > Domain assign, update & delete Screenshots Video
Table page > Hard delete Screenshots Video
Failed  Pages/EntityVersionPages.spec.js • 4 failed tests • cypress-ci-psql-oss-7534660178-1

View Output Video

Test Artifacts
Version page tests for data assets > Stored Procedure version page should work properly > Stored Procedure version page should show description, tag and child field name changes properly Screenshots Video
Version page tests for data assets > Stored Procedure version page should work properly > Stored Procedure version page should show owner changes properly Screenshots Video
Version page tests for data assets > Stored Procedure version page should work properly > Stored Procedure version page should show tier changes properly Screenshots Video
Version page tests for data assets > Stored Procedure version page should work properly > Stored Procedure version page should show changes after soft deleted Screenshots Video
Failed  Pages/ServiceVersionPage.spec.js • 4 failed tests • cypress-ci-psql-oss-7534660178-1

View Output Video

Test Artifacts
Common prerequisite for service version test > Search service version page > Search service version page should show edited tags and description changes properly Screenshots Video
Common prerequisite for service version test > Search service version page > Search version page should show owner changes properly Screenshots Video
Common prerequisite for service version test > Search service version page > Search version page should show tier changes properly Screenshots Video
Common prerequisite for service version test > Search service version page > Search version page should show version details after soft deleted Screenshots Video
Failed  Service/postgres.spec.js • 1 failed test • cypress-ci-psql-oss-7534660178-1

View Output Video

Test Artifacts
Postgres Ingestion > Verify if usage is ingested properly Screenshots Video

The first 5 failed specs are shown, see all 13 specs in Cypress Cloud.

Review all test suite changes for PR #14695 ↗︎

@harshach harshach merged commit b4b1b2e into main Jan 16, 2024
15 of 18 checks passed
@harshach harshach deleted the issue-14694 branch January 16, 2024 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-madlani chirag-madlani chirag-madlani approved these changes

Assignees
No one assigned
Labels
backend e2e This will trigger e2e test workflows safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harshach @chirag-madlani