Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cypress): main failures #14725

Merged
merged 12 commits into from
Jan 17, 2024
Merged

fix(cypress): main failures #14725

merged 12 commits into from
Jan 17, 2024

Conversation

chirag-madlani
Copy link
Collaborator

Describe your changes:

Fixes

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@chirag-madlani chirag-madlani added the e2e This will trigger e2e test workflows label Jan 16, 2024
@github-actions github-actions bot added the UI UI specific issues label Jan 16, 2024
@github-actions github-actions bot added the safe to test Add this label to run secure Github workflows on PRs label Jan 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 52%
 53.12% (26954/50744) 35.29% (10748/30452) 33.98% (3151/9274)

@cypress Cypress
Copy link

cypress bot commented Jan 16, 2024 •
edited
Loading

1 failed test on run #32976 ↗︎

1 599 40 0 Flakiness 0

Details:

skip query ingestion for postgres
Project: openmetadata Commit: a3b2df74d2
Status: Failed Duration: 32:12 💡
Started: Jan 17, 2024 1:00 PM Ended: Jan 17, 2024 1:32 PM
Failed  cypress/e2e/Pages/redirections.spec.js • 1 failed test • cypress-ci-psql-oss-7555853032-1

View Output Video

Test Artifacts
Redirection link should work properly > Check mydata redirection links on navbar Screenshots Video

Review all test suite changes for PR #14725 ↗︎

@chirag-madlani chirag-madlani marked this pull request as draft January 17, 2024 03:38
@chirag-madlani chirag-madlani marked this pull request as ready for review January 17, 2024 07:30
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@chirag-madlani chirag-madlani merged commit 4fa2c6d into main Jan 17, 2024
17 of 19 checks passed
@chirag-madlani chirag-madlani deleted the fix-cy-main branch January 17, 2024 13:58
Abhishek332 pushed a commit to Abhishek332/OpenMetadata that referenced this pull request Jan 25, 2024
@chirag-madlani @Abhishek332
fix(cypress): main failures (open-metadata#14725)
6e47492 
* fix(cypress): main failures

* fix tests

* fix users spec

* fix table spec

* fix users spec

* skip failures

* skip query ingestion for postgres
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaileshParmar11 ShaileshParmar11 ShaileshParmar11 approved these changes

@harshach harshach Awaiting requested review from harshach

@karanh37 karanh37 Awaiting requested review from karanh37

Assignees
No one assigned
Labels
e2e This will trigger e2e test workflows safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chirag-madlani @ShaileshParmar11