Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: update ENTITY_TYPE and ENTITY_FIELD in EntityLink.g4 #14732

Merged
merged 2 commits into from
Jan 16, 2024
Merged

Minor: update ENTITY_TYPE and ENTITY_FIELD in EntityLink.g4 #14732

merged 2 commits into from
Jan 16, 2024

Conversation

Sachin-chaurasiya
Copy link
Contributor

@Sachin-chaurasiya Sachin-chaurasiya commented Jan 16, 2024 •
edited
Loading

Describe your changes:

I worked on updating the ENTITY_TYPE and ENTITY_FIELD in EntityLink.g4

Type of change:

  • Improvement

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Sachin-chaurasiya Sachin-chaurasiya self-assigned this Jan 16, 2024
@github-actions github-actions bot added backend safe to test Add this label to run secure Github workflows on PRs UI UI specific issues labels Jan 16, 2024
@Sachin-chaurasiya Sachin-chaurasiya marked this pull request as draft January 16, 2024 13:50
@Sachin-chaurasiya Sachin-chaurasiya changed the title Minor: update ENTITY_TYPE in EntityLink.g4 Minor: update ENTITY_TYPE and ENTITY_FIELD in EntityLink.g4 Jan 16, 2024
@Sachin-chaurasiya Sachin-chaurasiya marked this pull request as ready for review January 16, 2024 13:58
@chirag-madlani chirag-madlani merged commit 1a83a11 into main Jan 16, 2024
13 checks passed
@chirag-madlani chirag-madlani deleted the fix-entitylink-antlr-grammar branch January 16, 2024 14:38
Abhishek332 pushed a commit to Abhishek332/OpenMetadata that referenced this pull request Jan 25, 2024
@Sachin-chaurasiya @Abhishek332
Minor: update ENTITY_TYPE and ENTITY_FIELD in EntityLink.g4 (open…
609138a 
…-metadata#14732)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@karanh37 karanh37 Awaiting requested review from karanh37

@ayush-shah ayush-shah Awaiting requested review from ayush-shah

Assignees

@Sachin-chaurasiya Sachin-chaurasiya

Labels
backend safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sachin-chaurasiya @chirag-madlani