Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort by display name in owner and mentions list #14734

Merged
merged 6 commits into from
Jan 22, 2024
Merged

Conversation

karanh37
Copy link
Contributor

Describe your changes:

Fixes Task 1 and 2 of #12981

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added UI UI specific issues safe to test Add this label to run secure Github workflows on PRs labels Jan 16, 2024
Copy link
Contributor

github-actions bot commented Jan 16, 2024

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 52%
52.58% (26867/51096) 35.1% (10741/30602) 33.46% (3131/9357)

chirag-madlani
chirag-madlani previously approved these changes Jan 19, 2024
Copy link

cypress bot commented Jan 19, 2024

7 failed tests on run #33010 ↗︎

7 604 32 1 Flakiness 0

Details:

fix cypress
Project: openmetadata Commit: 268296e17f
Status: Failed Duration: 35:35 💡
Started: Jan 22, 2024 1:48 PM Ended: Jan 22, 2024 2:23 PM
Failed  Service/ServiceIngestion.spec.ts • 1 failed test • cypress-ci-psql-oss-7611907106-1

View Output Video

Test Artifacts
S3 Ingestion > Update description and verify description after re-run Screenshots Video
Failed  Pages/DataQualityAndProfiler.spec.js • 1 failed test • cypress-ci-psql-oss-7611907106-1

View Output Video

Test Artifacts
Data Quality and Profiler should work properly > Update profiler setting modal Screenshots Video
Failed  Service/postgres.spec.js • 1 failed test • cypress-ci-psql-oss-7611907106-1

View Output Video

Test Artifacts
Postgres Ingestion > Verify if usage is ingested properly Screenshots Video
Failed  Features/CustomMetric.spec.js • 1 failed test • cypress-ci-psql-oss-7611907106-1

View Output Video

Test Artifacts
Custom Metric > Create table custom metric Screenshots Video
Failed  Features/QueryEntity.spec.js • 1 failed test • cypress-ci-psql-oss-7611907106-1

View Output Video

Test Artifacts
Query Entity > Update owner, description and tag Screenshots Video

The first 5 failed specs are shown, see all 7 specs in Cypress Cloud.

Review all test suite changes for PR #14734 ↗︎

Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@chirag-madlani chirag-madlani merged commit fd7a3f1 into main Jan 22, 2024
14 of 18 checks passed
@chirag-madlani chirag-madlani deleted the issue-12981 branch January 22, 2024 15:41
Abhishek332 pushed a commit to Abhishek332/OpenMetadata that referenced this pull request Jan 25, 2024
* sort by display name in owner and mentions list

* maintain sort order

* fix cypress

---------

Co-authored-by: Chirag Madlani <12962843+chirag-madlani@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e This will trigger e2e test workflows safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants