Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: Update Incident Manager Flow #14735

Merged
merged 3 commits into from
Jan 17, 2024

Conversation

TeddyCr
Copy link
Contributor

@TeddyCr TeddyCr commented Jan 16, 2024

Describe your changes:

  • Remove task opening in "New" state
  • Added task opening in "Ack" state (in addition to Assigned)
  • Added logic to support New -> Resolved (in this scenario we won't close a task as no task will exists)
  • Remove incidentId clean up from testCase on resolution. We need to keep to show the failure was resolved on the DQ page

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.
  • I have added a test that covers the exact scenario we are fixing. For complex issues, comment the issue number in the test for future reference.

@TeddyCr TeddyCr requested a review from a team as a code owner January 16, 2024 15:46
@github-actions github-actions bot added backend Ingestion safe to test Add this label to run secure Github workflows on PRs labels Jan 16, 2024
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@pmbrull pmbrull merged commit 085dfc0 into open-metadata:main Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend data quality Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants