#9269 - Add MSSQL Stored Procedure Support #14739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Ingestion
backend
safe to test
|
harshach
approved these changes
Jan 16, 2024
ayush-shah
reviewed
Jan 17, 2024
Comment on lines
+162
to
+166
|
|
||
| -- Add supportsQueryComment to MSSQL | ||
| update dbservice_entity | ||
| set json = JSON_SET(json, '$.connection.config.supportsQueryComment', true) | ||
| where serviceType = 'Mssql'; |
There was a problem hiding this comment.
@pmbrull as supportsQueryComment by default is set to true, if it doesn't find it, it will be set to true, do we need a migration in these cases?
There was a problem hiding this comment.
Without it the server did not start. I don't think the problem is the value but the server expecting the key there I guess
IceS2
pushed a commit
that referenced
this pull request
Jan 17, 2024
* Remove unnecessary field * Remove unnecessary field * Support query comments in MSSQL * Remove unnecessary field * Format * Add external type * Add MSSQL SP support
Abhishek332
pushed a commit
to Abhishek332/OpenMetadata
that referenced
this pull request
Jan 25, 2024
…a#14739) * Remove unnecessary field * Remove unnecessary field * Support query comments in MSSQL * Remove unnecessary field * Format * Add external type * Add MSSQL SP support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Fixes #9269
Also:
supportsQueryCommentto MSSQL. Tested it with our instance and it's all good thereleft a comment in the issue with the SP lineage query we are using. It's not great since I did not find a way to link SP <> Query via session ID or anything similar, so we might end up having some false positives.
Let's see if someone in the community is more versed in MSSQL than I am and can chip in
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>