Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Expression Parsing and Failure in AbstractConsumer #14753

Merged
merged 1 commit into from
Jan 17, 2024
Merged

[Fix] Expression Parsing and Failure in AbstractConsumer #14753

merged 1 commit into from
Jan 17, 2024

Conversation

mohityadav766
Copy link
Contributor

Describe your changes:

Fixes Issue in expression parsing and failure in abstractConsumer leading to memory leak

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added UI UI specific issues backend labels Jan 17, 2024
@github-actions github-actions bot added the safe to test Add this label to run secure Github workflows on PRs label Jan 17, 2024
@mohityadav766 mohityadav766 self-assigned this Jan 17, 2024
@mohityadav766 mohityadav766 merged commit 7dcdc1a into main Jan 17, 2024
17 checks passed
@mohityadav766 mohityadav766 deleted the fixExpressionParsing branch January 17, 2024 07:52
@github-actions GitHub Actions
Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 52%
 53.12% (26954/50744) 35.29% (10748/30452) 33.98% (3151/9274)

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

IceS2 pushed a commit that referenced this pull request Jan 17, 2024
@mohityadav766 @IceS2
Fix Expression Parsing (#14753)
5bf3201
Abhishek332 pushed a commit to Abhishek332/OpenMetadata that referenced this pull request Jan 25, 2024
@mohityadav766 @Abhishek332
Fix Expression Parsing (open-metadata#14753)
82e8927
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@harshach harshach Awaiting requested review from harshach

@karanh37 karanh37 Awaiting requested review from karanh37

@akash-jain-10 akash-jain-10 Awaiting requested review from akash-jain-10

Assignees

@mohityadav766 mohityadav766

Labels
backend safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mohityadav766 @chirag-madlani