Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: fix incident filtering logic #14760

Merged
merged 2 commits into from
Jan 18, 2024
Merged

Minor: fix incident filtering logic #14760

merged 2 commits into from
Jan 18, 2024

Conversation

TeddyCr
Copy link
Contributor

@TeddyCr TeddyCr commented Jan 17, 2024

Describe your changes:

  • When filtering for the latest incidents, assignee and status must be filtered in the outer query.

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@TeddyCr TeddyCr requested a review from a team as a code owner January 17, 2024 10:53
@github-actions github-actions bot added backend Ingestion safe to test Add this label to run secure Github workflows on PRs labels Jan 17, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@TeddyCr TeddyCr enabled auto-merge (squash) January 18, 2024 07:03
@TeddyCr TeddyCr merged commit 71592df into open-metadata:main Jan 18, 2024
20 checks passed
Abhishek332 pushed a commit to Abhishek332/OpenMetadata that referenced this pull request Jan 25, 2024
@TeddyCr @Abhishek332
fix: filtering logic when getting latest incidents (open-metadata#14760)
3e8f5bd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmbrull pmbrull pmbrull approved these changes

Assignees
No one assigned
Labels
backend data quality Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TeddyCr @pmbrull