Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: sidebar ui fix #14761

Merged
merged 3 commits into from
Jan 17, 2024
Merged

MINOR: sidebar ui fix #14761

merged 3 commits into from
Jan 17, 2024

Conversation

Ashish8689
Copy link
Contributor

@Ashish8689 Ashish8689 commented Jan 17, 2024 •
edited
Loading

Describe your changes:

  • Remove open/active Dropdown background color
  • fix the background patch from the dropdown element while hovering
image
Screen.Recording.2024-01-17.at.7.08.41.PM.mov

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Ashish8689 Ashish8689 added the UI UI specific issues label Jan 17, 2024
@Ashish8689 Ashish8689 self-assigned this Jan 17, 2024
@github-actions github-actions bot added the safe to test Add this label to run secure Github workflows on PRs label Jan 17, 2024
karanh37
karanh37 previously approved these changes Jan 17, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 52%
 53.12% (26954/50744) 35.29% (10748/30452) 33.98% (3151/9274)

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@chirag-madlani chirag-madlani merged commit 0d7833b into main Jan 17, 2024
14 checks passed
@chirag-madlani chirag-madlani deleted the sidebar-ui branch January 17, 2024 16:19
Abhishek332 pushed a commit to Abhishek332/OpenMetadata that referenced this pull request Jan 25, 2024
@Ashish8689 @Abhishek332
MINOR: sidebar ui fix (open-metadata#14761)
1457903 
* MINOR: sidebar ui fix

* fix app icon movement
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@karanh37 karanh37 karanh37 left review comments

@harshach harshach Awaiting requested review from harshach

Assignees

@Ashish8689 Ashish8689

Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ashish8689 @chirag-madlani @karanh37