MINOR: added fall back to table metric computation #14771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Ingestion
safe to test
ayush-shah
reviewed
Jan 18, 2024
| ) | ||
|
|
||
|
|
||
| class SnowflakeTableMetricComputer(BaseTableMetricComputer): |
There was a problem hiding this comment.
Should we have a file structure similar to what we have for interfaces?
that would help keep the files small and specific. wdyt?
- orm
-- functions
--- snowflake
---- table_metric_computer.py
--- bigquery
---- table_metric_computer.py
something like that
There was a problem hiding this comment.
🤔 we could, though I am not sure it is necessary at this point. We have a small file ~400+ lines with tightly coupled classes.
There was a problem hiding this comment.
okayy, maybe in the future when we add more dialects / dbs in the file, we can make it more readable in the directory structure. Approving Thanks 🙌
|
ayush-shah
approved these changes
Jan 18, 2024
Abhishek332
pushed a commit
to Abhishek332/OpenMetadata
that referenced
this pull request
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Community thread: https://openmetadata.slack.com/archives/C02B6955S4S/p1705391254940659
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>Improvement