MINOR: Fixed Athena e2e counts and change to e2e_db #14774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Ingestion
safe to test
OnkarVO7
commented
Jan 18, 2024
| @@ -49,7 +49,7 @@ def get_database_tags(self, name: str) -> Optional[LFTags]: | |||
| return lf_tags.LFTagOnDatabase | |||
| except Exception as exc: | |||
| logger.debug(traceback.format_exc()) | |||
| logger.error( | |||
There was a problem hiding this comment.
fetching tags is optional so we'll log warning instead of an error
|
ulixius9
approved these changes
Jan 19, 2024
Abhishek332
pushed a commit
to Abhishek332/OpenMetadata
that referenced
this pull request
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Fixed the athena e2e to point at new db
e2e_dband modified counts accordingly.Changed logger for athena tags from error->warning.
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>