-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(fix #13822):Support for Custom Properties for various entities #14781
Conversation
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
7 failed tests on run #32998 ↗︎
Details:
Service/ServiceIngestion.spec.ts • 1 failed test • cypress-ci-psql-oss-7582411338-1
Pages/DataQualityAndProfiler.spec.js • 1 failed test • cypress-ci-psql-oss-7582411338-1
Flow/Lineage.spec.js • 2 failed tests • cypress-ci-psql-oss-7582411338-1
Service/postgres.spec.js • 1 failed test • cypress-ci-psql-oss-7582411338-1
Features/QueryEntity.spec.js • 1 failed test • cypress-ci-psql-oss-7582411338-1
The first 5 failed specs are shown, see all 6 specs in Cypress Cloud. Review all test suite changes for PR #14781 ↗︎ |
openmetadata-ui/src/main/resources/ui/cypress/e2e/Pages/Entity.spec.ts
Outdated
Show resolved
Hide resolved
openmetadata-ui/src/main/resources/ui/cypress/e2e/Pages/Entity.spec.ts
Outdated
Show resolved
Hide resolved
...etadata-ui/src/main/resources/ui/src/components/Entity/EntityRightPanel/EntityRightPanel.tsx
Show resolved
Hide resolved
...etadata-ui/src/main/resources/ui/src/pages/SearchIndexDetailsPage/SearchIndexDetailsPage.tsx
Show resolved
Hide resolved
...etadata-ui/src/main/resources/ui/src/components/Entity/EntityRightPanel/EntityRightPanel.tsx
Outdated
Show resolved
Hide resolved
...a-ui/src/main/resources/ui/src/components/common/CustomPropertyTable/CustomPropertyTable.tsx
Outdated
Show resolved
Hide resolved
Quality Gate passed for 'open-metadata-ui'Kudos, no new issues were introduced! 0 New issues |
…ntities (open-metadata#14781) * add Custom Properties for various entities * type fixes and code refactor * fix failing test & minor fix --------- Co-authored-by: Chirag Madlani <12962843+chirag-madlani@users.noreply.github.com>
Describe your changes:
Fixes #13822
I worked on providing support for Custom Properties for the entities in Custom Property.
Screen.Recording.2024-01-19.at.12.05.56.AM.mov
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>