Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix #13822):Support for Custom Properties for various entities #14781

Merged
merged 4 commits into from
Jan 19, 2024

Conversation

harsh-vador
Copy link
Contributor

Describe your changes:

Fixes #13822

I worked on providing support for Custom Properties for the entities in Custom Property.

Screen.Recording.2024-01-19.at.12.05.56.AM.mov

Type of change:

  • Improvement

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added the UI UI specific issues label Jan 18, 2024
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

Copy link

cypress bot commented Jan 19, 2024

7 failed tests on run #32998 ↗︎

7 604 32 0 Flakiness 0

Details:

fix failing test & minor fix
Project: openmetadata Commit: fe5296d521
Status: Failed Duration: 34:12 💡
Started: Jan 19, 2024 10:34 AM Ended: Jan 19, 2024 11:08 AM
Failed  Service/ServiceIngestion.spec.ts • 1 failed test • cypress-ci-psql-oss-7582411338-1

View Output Video

Test Artifacts
S3 Ingestion > Update description and verify description after re-run Screenshots Video
Failed  Pages/DataQualityAndProfiler.spec.js • 1 failed test • cypress-ci-psql-oss-7582411338-1

View Output Video

Test Artifacts
Data Quality and Profiler should work properly > Update profiler setting modal Screenshots Video
Failed  Flow/Lineage.spec.js • 2 failed tests • cypress-ci-psql-oss-7582411338-1

View Output Video

Test Artifacts
Lineage verification > Lineage Add Node for entity Container Screenshots Video
Lineage verification > Lineage Remove Node between Container Screenshots Video
Failed  Service/postgres.spec.js • 1 failed test • cypress-ci-psql-oss-7582411338-1

View Output Video

Test Artifacts
Postgres Ingestion > Verify if usage is ingested properly Screenshots Video
Failed  Features/QueryEntity.spec.js • 1 failed test • cypress-ci-psql-oss-7582411338-1

View Output Video

Test Artifacts
Query Entity > Update owner, description and tag Screenshots Video

The first 5 failed specs are shown, see all 6 specs in Cypress Cloud.

Review all test suite changes for PR #14781 ↗︎

Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 52%
52.57% (26858/51091) 35.1% (10735/30586) 33.45% (3130/9356)

Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@chirag-madlani chirag-madlani merged commit 6d91757 into open-metadata:main Jan 19, 2024
12 of 20 checks passed
Abhishek332 pushed a commit to Abhishek332/OpenMetadata that referenced this pull request Jan 25, 2024
…ntities (open-metadata#14781)

* add Custom Properties for various entities

* type fixes and code refactor

* fix failing test & minor fix

---------

Co-authored-by: Chirag Madlani <12962843+chirag-madlani@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e This will trigger e2e test workflows safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support for most custom properties to right side panel
2 participants