-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MINOR: Change sidbar data-quality menu #14789
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
safe to test
Add this label to run secure Github workflows on PRs
label
Jan 19, 2024
Ashish8689
requested review from
harshach,
karanh37 and
chirag-madlani
as code owners
January 19, 2024 08:08
openmetadata-ui/src/main/resources/ui/src/constants/constants.ts
Outdated
Show resolved
Hide resolved
4 failed tests on run #32999 ↗︎
Details:
Service/ServiceIngestion.spec.ts • 1 failed test • cypress-ci-psql-oss-7584442562-1
Pages/Domains.spec.js • 1 failed test • cypress-ci-psql-oss-7584442562-1
Service/postgres.spec.js • 1 failed test • cypress-ci-psql-oss-7584442562-1
Pages/GlossaryVersionPage.spec.js • 1 failed test • cypress-ci-psql-oss-7584442562-1
Review all test suite changes for PR #14789 ↗︎ |
Sachin-chaurasiya
approved these changes
Jan 19, 2024
Quality Gate passed for 'open-metadata-ui'Kudos, no new issues were introduced! 0 New issues |
chirag-madlani
approved these changes
Jan 19, 2024
Abhishek332
pushed a commit
to Abhishek332/OpenMetadata
that referenced
this pull request
Jan 25, 2024
* Change sidbar data-quality menu * minor changes * localization keys added * minor fix * fix unit test * removed unused routes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
e2e
This will trigger e2e test workflows
safe to test
Add this label to run secure Github workflows on PRs
UI
UI specific issues
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Data Quality
menu toObservalbility
Alerts
in the menuScreen.Recording.2024-01-19.at.1.34.02.PM.mov
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>