Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: Change sidbar data-quality menu #14789

Merged
merged 7 commits into from
Jan 19, 2024
Merged

Conversation

Ashish8689
Copy link
Contributor

@Ashish8689 Ashish8689 commented Jan 19, 2024

Describe your changes:

  • Rename Data Quality menu to Observalbility
  • Added Alerts in the menu
Screen.Recording.2024-01-19.at.1.34.02.PM.mov

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Ashish8689 Ashish8689 added the UI UI specific issues label Jan 19, 2024
@Ashish8689 Ashish8689 self-assigned this Jan 19, 2024
@github-actions github-actions bot added the safe to test Add this label to run secure Github workflows on PRs label Jan 19, 2024
@Ashish8689 Ashish8689 marked this pull request as ready for review January 19, 2024 08:08
Copy link

cypress bot commented Jan 19, 2024

4 failed tests on run #32999 ↗︎

4 607 32 0 Flakiness 0

Details:

Merge branch 'main' into sidebar-observability
Project: openmetadata Commit: 11b43bdb1f
Status: Failed Duration: 34:12 💡
Started: Jan 19, 2024 1:48 PM Ended: Jan 19, 2024 2:22 PM
Failed  Service/ServiceIngestion.spec.ts • 1 failed test • cypress-ci-psql-oss-7584442562-1

View Output Video

Test Artifacts
S3 Ingestion > Update description and verify description after re-run Screenshots Video
Failed  Pages/Domains.spec.js • 1 failed test • cypress-ci-psql-oss-7584442562-1

View Output Video

Test Artifacts
Domain page should work properly > Remove Domain from entity should work properly Screenshots Video
Failed  Service/postgres.spec.js • 1 failed test • cypress-ci-psql-oss-7584442562-1

View Output Video

Test Artifacts
Postgres Ingestion > Verify if usage is ingested properly Screenshots Video
Failed  Pages/GlossaryVersionPage.spec.js • 1 failed test • cypress-ci-psql-oss-7584442562-1

View Output Video

Test Artifacts
Glossary and glossary term version pages should work properly > Glossary term version page should display owner and reviewer changes properly Screenshots Video

Review all test suite changes for PR #14789 ↗︎

Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 52%
52.58% (26866/51094) 35.05% (10708/30551) 33.48% (3133/9357)

Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@chirag-madlani chirag-madlani merged commit 0415a90 into main Jan 19, 2024
17 of 25 checks passed
@chirag-madlani chirag-madlani deleted the sidebar-observability branch January 19, 2024 16:43
Abhishek332 pushed a commit to Abhishek332/OpenMetadata that referenced this pull request Jan 25, 2024
* Change sidbar data-quality menu

* minor changes

* localization keys added

* minor fix

* fix unit test

* removed unused routes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e This will trigger e2e test workflows safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants