Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #14661: Improve Messages in the UI #14805

Merged
merged 17 commits into from
Jan 24, 2024
Merged

fix #14661: Improve Messages in the UI #14805

merged 17 commits into from
Jan 24, 2024

Conversation

harsh-vador
Copy link
Contributor

@harsh-vador harsh-vador commented Jan 20, 2024 •
edited
Loading

Describe your changes:

Fixes #14661

I worked on improving the no data available messages on the UI.

Contribute with Stars to help data enthusiasts discover OpenMetadata! ->

Screenshot 2024-01-20 at 11 01 36 AM

We have not found any activity within the data assets you own or the ones you are currently following ->

Screenshot 2024-01-20 at 11 08 28 AM

There aren't any open tasks. Currently, there are no pending tasks assigned to you ->

Screenshot 2024-01-20 at 11 09 02 AM

There are no instances where you or your team have been referenced in any activities->

Screenshot 2024-01-20 at 11 10 11 AM

My Data, No worries! It's the perfect moment to rethink your goals and accelerate your progress. Let's turn this into an opportunity for growth!, Total Data Assets ->

Screenshot 2024-01-20 at 11 19 52 AM

KPIs->

Screenshot 2024-01-20 at 11 32 24 AM

"Fantastic! You've hit your target ahead of schedule. Great job!" -> "
Screenshot 2024-01-24 at 11 57 47 AM

Table -> Profiler & Data Quality -> Data Quality -> Test Cases

Screenshot 2024-01-20 at 11 33 19 AM

Table -> Profiler & Data Quality -> Data Quality -> Pipeline

Screenshot 2024-01-20 at 11 33 54 AM

Screenshot 2024-01-24 at 11 54 29 AM

Screenshot 2024-01-20 at 12 13 09 PM
Screenshot 2024-01-20 at 12 13 23 PM

Screenshot 2024-01-24 at 1 18 46 PM

Type of change:

  • Improvement

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added the UI UI specific issues label Jan 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@github-actions GitHub Actions
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@github-actions GitHub Actions
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@github-actions GitHub Actions
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@github-actions GitHub Actions
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@github-actions GitHub Actions
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@chirag-madlani chirag-madlani added safe to test Add this label to run secure Github workflows on PRs e2e This will trigger e2e test workflows labels Jan 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 23, 2024 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 52%
 52.78% (27086/51318) 35.22% (10819/30722) 33.69% (3164/9391)

@harsh-vador harsh-vador marked this pull request as ready for review January 24, 2024 06:39
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
53.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@chirag-madlani chirag-madlani merged commit 020254a into open-metadata:main Jan 24, 2024
15 of 20 checks passed
Abhishek332 pushed a commit to Abhishek332/OpenMetadata that referenced this pull request Jan 25, 2024
@harsh-vador @Abhishek332
fix open-metadata#14661: Improve Messages in the UI (open-metadata#14805
92e5754 
)

* Improve Messages in the UI

* fix failing tests & add locale files

* change message to locale

* add locale files

* change no pipeline message

* add message for test suite pipeline & kpi

* address comments

* add locale files

* change delete message

* fix failing test

* change incorrect spelling mistakes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sachin-chaurasiya Sachin-chaurasiya Sachin-chaurasiya left review comments

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@harshach harshach Awaiting requested review from harshach

@karanh37 karanh37 Awaiting requested review from karanh37

@akash-jain-10 akash-jain-10 Awaiting requested review from akash-jain-10

Assignees
No one assigned
Labels
e2e This will trigger e2e test workflows Ingestion safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve Messages in the UI
3 participants
@harsh-vador @chirag-madlani @Sachin-chaurasiya