support for custom property for glossary term #14822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
harshach
added
the
safe to test
Jest test CoverageUI tests summary
|
harsh-vador
requested review from
harshach,
karanh37,
chirag-madlani and
Sachin-chaurasiya
as code owners
...etadata-ui/src/main/resources/ui/src/components/Entity/EntityRightPanel/EntityRightPanel.tsx
Outdated
Show resolved
Hide resolved
.../src/main/resources/ui/src/components/Glossary/GlossaryDetails/GlossaryDetails.component.tsx
Show resolved
Hide resolved
...ui/src/components/Glossary/GlossaryDetailsRightPanel/GlossaryDetailsRightPanel.component.tsx
Outdated
Show resolved
Hide resolved
...in/resources/ui/src/components/Glossary/GlossaryTerms/tabs/GlossaryOverviewTab.component.tsx
Outdated
Show resolved
Hide resolved
...a-ui/src/main/resources/ui/src/components/common/CustomPropertyTable/CustomPropertyTable.tsx
Outdated
Show resolved
Hide resolved
...a-ui/src/main/resources/ui/src/components/common/CustomPropertyTable/CustomPropertyTable.tsx
Outdated
Show resolved
Hide resolved
9 failed tests on run #33064 ↗︎
Details:
|
||||||||||||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Glossary page should work properly > Update glossary term |
Screenshots
Video
|
|
Pages/DataQualityAndProfiler.spec.js • 1 failed test • cypress-ci-psql-oss-7665863451-1
| Test | Artifacts | |
|---|---|---|
| Data Quality and Profiler should work properly > Update profiler setting modal |
Screenshots
Video
|
|
Pages/Permission.spec.ts • 3 failed tests • cypress-ci-psql-oss-7665863451-1
Features/ActivityFeed.spec.js • 1 failed test • cypress-ci-psql-oss-7665863451-1
| Test | Artifacts | |
|---|---|---|
| Activity feed > Assigned task should appear to task tab |
Screenshots
Video
|
|
Flow/Task.spec.js • 2 failed tests • cypress-ci-psql-oss-7665863451-1
| Test | Artifacts | |
|---|---|---|
| Task flow should work > Task flow for table description |
Screenshots
Video
|
|
| Task flow should work > Task flow for table tags |
Screenshots
Video
|
|
The first 5 failed specs are shown, see all 6 specs in Cypress Cloud.
Review all test suite changes for PR #14822 ↗︎
Sachin-chaurasiya
had a problem deploying
to
test
GitHub Actions
Failure
Sachin-chaurasiya
had a problem deploying
to
test
GitHub Actions
Failure
Sachin-chaurasiya
had a problem deploying
to
test
GitHub Actions
Failure
Sachin-chaurasiya
had a problem deploying
to
test
GitHub Actions
Failure
Sachin-chaurasiya
temporarily deployed
to
test
GitHub Actions
Inactive
Sachin-chaurasiya
had a problem deploying
to
test
GitHub Actions
Failure
Sachin-chaurasiya
had a problem deploying
to
test
GitHub Actions
Failure
Sachin-chaurasiya
had a problem deploying
to
test
GitHub Actions
Failure
Sachin-chaurasiya
had a problem deploying
to
test
GitHub Actions
Error
Sachin-chaurasiya
had a problem deploying
to
test
GitHub Actions
Error
Sachin-chaurasiya
had a problem deploying
to
test
GitHub Actions
Error
Sachin-chaurasiya
had a problem deploying
to
test
GitHub Actions
Error
Sachin-chaurasiya
had a problem deploying
to
test
GitHub Actions
Error
Sachin-chaurasiya
had a problem deploying
to
test
GitHub Actions
Error
Sachin-chaurasiya
had a problem deploying
to
test
GitHub Actions
Error
Sachin-chaurasiya
had a problem deploying
to
test
GitHub Actions
Error
Sachin-chaurasiya
had a problem deploying
to
test
GitHub Actions
Failure
Sachin-chaurasiya
had a problem deploying
to
test
GitHub Actions
Failure
Sachin-chaurasiya
had a problem deploying
to
test
GitHub Actions
Failure
Sachin-chaurasiya
had a problem deploying
to
test
GitHub Actions
Failure
Sachin-chaurasiya
approved these changes
Jan 26, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
I worked on adding support for custom property for glossary term
Screen.Recording.2024-01-24.at.4.39.38.PM.mov
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>