Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fix Search service #14837

Merged
merged 2 commits into from
Jan 25, 2024
Merged

Minor fix Search service #14837

merged 2 commits into from
Jan 25, 2024

Conversation

07Himank
Copy link
Contributor

I worked on ... because ... Minor fix Search service

Type of change:

  • Bug fix
  • Improvement

@07Himank 07Himank added the safe to test Add this label to run secure Github workflows on PRs label Jan 24, 2024
@07Himank 07Himank requested a review from a team as a code owner January 24, 2024 09:57
mohityadav766
mohityadav766 previously approved these changes Jan 24, 2024
View reviewed changes
@07Himank 07Himank added the e2e This will trigger e2e test workflows label Jan 25, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@cypress Cypress
Copy link

cypress bot commented Jan 25, 2024

12 failed tests on run #33050 ↗︎

12 599 32 1 Flakiness 0

Details:

fix minor search fixes
Project: openmetadata Commit: dedbde8d1c
Status: Failed Duration: 38:10 💡
Started: Jan 25, 2024 11:37 AM Ended: Jan 25, 2024 12:15 PM
Failed  Service/ServiceIngestion.spec.ts • 3 failed tests • cypress-ci-psql-oss-7653718359-1

View Output Video

Test Artifacts
S3 Ingestion > Update description and verify description after re-run Screenshots Video
BigQuery Ingestion > Create & Ingest BigQuery service Screenshots Video
Kafka Ingestion > Update description and verify description after re-run Screenshots Video
Failed  Flow/Lineage.spec.js • 3 failed tests • cypress-ci-psql-oss-7653718359-1

View Output Video

Test Artifacts
Lineage verification > Lineage Remove Node between Topic Screenshots Video
Lineage verification > Lineage Remove Node between ML Model Screenshots Video
Lineage verification > Lineage Remove Node between Container Screenshots Video
Failed  Service/redshiftWithDBT.spec.js • 2 failed tests • cypress-ci-psql-oss-7653718359-1

View Output Video

Test Artifacts
RedShift Ingestion > Add DBT ingestion Screenshots Video
RedShift Ingestion > Validate DBT is ingested properly Screenshots Video
Failed  Service/postgres.spec.js • 1 failed test • cypress-ci-psql-oss-7653718359-1

View Output Video

Test Artifacts
Postgres Ingestion > Verify if usage is ingested properly Screenshots Video
Failed  Features/QueryEntity.spec.js • 1 failed test • cypress-ci-psql-oss-7653718359-1

View Output Video

Test Artifacts
Query Entity > Update owner, description and tag Screenshots Video

The first 5 failed specs are shown, see all 7 specs in Cypress Cloud.

Review all test suite changes for PR #14837 ↗︎

@Sachin-chaurasiya Sachin-chaurasiya merged commit cb7db8c into main Jan 25, 2024
19 of 31 checks passed
@Sachin-chaurasiya Sachin-chaurasiya deleted the minorFixSearchService branch January 25, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohityadav766 mohityadav766 mohityadav766 left review comments

Assignees
No one assigned
Labels
backend e2e This will trigger e2e test workflows safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@07Himank @mohityadav766 @Sachin-chaurasiya