Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: add axios@1.6.4 resolutions in package.json #14840

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Minor: add axios@1.6.4 resolutions in package.json #14840

merged 1 commit into from
Jan 24, 2024

Conversation

Sachin-chaurasiya
Copy link
Member

Describe your changes:

Fixes

I worked on adding axios@1.6.4 resolutions in package.json to make sure all the dependencies use Axios with version 1.6.4

Screen.Recording.2024-01-24.at.4.25.29.PM.mov

Type of change:

  • Improvement

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Sachin-chaurasiya Sachin-chaurasiya self-assigned this Jan 24, 2024
@github-actions github-actions bot added UI UI specific issues safe to test Add this label to run secure Github workflows on PRs labels Jan 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 52%
 52.78% (27077/51303) 35.2% (10810/30712) 33.69% (3164/9391)

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

chirag-madlani
chirag-madlani approved these changes Jan 24, 2024
View reviewed changes
Copy link
Collaborator

@chirag-madlani chirag-madlani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Sachin-chaurasiya 🚀

@Sachin-chaurasiya Sachin-chaurasiya merged commit 8c11777 into main Jan 24, 2024
15 of 16 checks passed
@Sachin-chaurasiya Sachin-chaurasiya deleted the axios-resolution-package-json branch January 24, 2024 12:23
Abhishek332 pushed a commit to Abhishek332/OpenMetadata that referenced this pull request Jan 25, 2024
@Sachin-chaurasiya @Abhishek332
Minor: add axios@1.6.4 resolutions in package.json (open-metadata#14840)
a0b1c17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@harshach harshach Awaiting requested review from harshach

@karanh37 karanh37 Awaiting requested review from karanh37

Assignees

@Sachin-chaurasiya Sachin-chaurasiya

Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sachin-chaurasiya @chirag-madlani