Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#13767: Remove ingestion pipeline action buttons and ingestion button if pipelineService is disabled #14847

Merged
merged 3 commits into from
Jan 25, 2024
Merged

#13767: Remove ingestion pipeline action buttons and ingestion button if pipelineService is disabled #14847

merged 3 commits into from
Jan 25, 2024

Conversation

Ashish8689
Copy link
Contributor

…

Describe your changes:

Fixes #13767

  • Remove ingestion pipeline action buttons pipeline service is disabled
  • Remove the Add Metadata ingestion button and Add service button if pipeline service is disabled
  • Change ingestion table message as per disable pipeline service
image image image

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Ashish8689 Ashish8689 added the UI UI specific issues label Jan 24, 2024
@Ashish8689 Ashish8689 self-assigned this Jan 24, 2024
@github-actions github-actions bot added the safe to test Add this label to run secure Github workflows on PRs label Jan 24, 2024
ShaileshParmar11
ShaileshParmar11 reviewed Jan 24, 2024
View reviewed changes
Copy link
Contributor

@ShaileshParmar11 ShaileshParmar11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left few comments

openmetadata-ui/src/main/resources/ui/src/components/Ingestion/Ingestion.component.tsx Outdated Show resolved Hide resolved
openmetadata-ui/src/main/resources/ui/src/components/Ingestion/IngestionListTable.component.tsx Show resolved Hide resolved
openmetadata-ui/src/main/resources/ui/src/utils/IngestionUtils.tsx Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 24, 2024 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 52%
 52.8% (27103/51336) 35.2% (10817/30728) 33.7% (3166/9394)

@Ashish8689
Copy link
Contributor Author

@ShaileshParmar11 @chirag-madlani changes made as per comments!

@ShaileshParmar11
Copy link
Contributor

can you please take care of code smell?

@Ashish8689
Copy link
Contributor Author

@ShaileshParmar11 the ingestion table code smell is handled!

@chirag-madlani chirag-madlani added the e2e This will trigger e2e test workflows label Jan 24, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@cypress Cypress
Copy link

cypress bot commented Jan 24, 2024

7 failed tests on run #33043 ↗︎

7 617 25 0 Flakiness 0

Details:

changes as per comments
Project: openmetadata Commit: 9c3304da03
Status: Failed Duration: 33:53 💡
Started: Jan 24, 2024 8:28 PM Ended: Jan 24, 2024 9:02 PM
Failed  Service/ServiceIngestion.spec.ts • 1 failed test • cypress-ci-psql-oss-7645684770-1

View Output Video

Test Artifacts
BigQuery Ingestion > Create & Ingest BigQuery service Screenshots Video
Failed  Pages/Users.spec.ts • 2 failed tests • cypress-ci-psql-oss-7645684770-1

View Output Video

Test Artifacts
User with different Roles > Data Consumer operations for settings page Screenshots Video
User with different Roles > Data Steward operations for settings page Screenshots Video
Failed  Service/redshiftWithDBT.spec.js • 2 failed tests • cypress-ci-psql-oss-7645684770-1

View Output Video

Test Artifacts
RedShift Ingestion > Add DBT ingestion Screenshots Video
RedShift Ingestion > Validate DBT is ingested properly Screenshots Video
Failed  Pages/GlossaryVersionPage.spec.js • 2 failed tests • cypress-ci-psql-oss-7645684770-1

View Output Video

Test Artifacts
Glossary and glossary term version pages should work properly > Glossary version page should display the owner and reviewer changes properly Screenshots Video
Glossary and glossary term version pages should work properly > Glossary term version page should display owner and reviewer changes properly Screenshots Video

Review all test suite changes for PR #14847 ↗︎

@Ashish8689 Ashish8689 merged commit f311d8d into main Jan 25, 2024
25 of 31 checks passed
@Ashish8689 Ashish8689 deleted the pipeline-disabled branch January 25, 2024 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaileshParmar11 ShaileshParmar11 ShaileshParmar11 approved these changes

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@harshach harshach Awaiting requested review from harshach

@karanh37 karanh37 Awaiting requested review from karanh37

@Sachin-chaurasiya Sachin-chaurasiya Awaiting requested review from Sachin-chaurasiya

Assignees

@Ashish8689 Ashish8689

Labels
e2e This will trigger e2e test workflows safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UI to disable ingestion pipeline actions if pipelineService is disabled
3 participants
@Ashish8689 @ShaileshParmar11 @chirag-madlani