Fix 13970: Fix Consecutive Array issue in Athena #14852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Ingestion
safe to test
|
TeddyCr
approved these changes
Jan 24, 2024
TeddyCr
reviewed
Jan 24, 2024
| } | ||
| if name in ["decimal"]: | ||
| col_type = types.DECIMAL | ||
| if name in ["decimal", "char", "varchar"]: |
There was a problem hiding this comment.
No need to change it, but you can use a set here for a more efficient lookup.
Abhishek332
pushed a commit
to Abhishek332/OpenMetadata
that referenced
this pull request
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Fixes #13970
The issue described was being caused because Array(Array) failed as the it needs item_type as argument and it was sent empty. As we don't cater to nested arrays for their children and their types, dataType will be Array, arrayDataType will be Array, dataTypeDisplay would be array<array<.....>>
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>