Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #11944: API support to fetch count for mentions #14858

Merged
merged 6 commits into from
Jan 28, 2024
Merged

Fix #11944: API support to fetch count for mentions #14858

merged 6 commits into from
Jan 28, 2024

Conversation

harshach
Copy link
Collaborator

@harshach harshach commented Jan 25, 2024 •
edited by Ashish8689
Loading

Describe your changes:

Fixes #11944

  • Used new count API for fetching the count of entities
  • remove the mentions tab from the entity page
  • change the mention filter in the user page to all mentions and display count for mention
image image image

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@harshach harshach requested a review from a team as a code owner January 25, 2024 07:39
@github-actions github-actions bot added backend safe to test Add this label to run secure Github workflows on PRs labels Jan 25, 2024
@github-actions github-actions bot added the UI UI specific issues label Jan 27, 2024
@github-actions GitHub Actions
Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 53%
 53.25% (27296/51256) 35.21% (10876/30889) 34.05% (3195/9382)

@Ashish8689 Ashish8689 added the e2e This will trigger e2e test workflows label Jan 27, 2024
@cypress Cypress
Copy link

cypress bot commented Jan 27, 2024 •
edited
Loading

Passing run #33078 ↗︎

0 683 25 0 Flakiness 0

Details:

Merge branch 'main' into issue-11944-v1
Project: openmetadata Commit: 255fd0eb5d
Status: Passed Duration: 35:10 💡
Started: Jan 28, 2024 9:21 AM Ended: Jan 28, 2024 9:56 AM

Review all test suite changes for PR #14858 ↗︎

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

The SonarCloud Quality Gate passed, but some issues were introduced.

3 New issues
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Sachin-chaurasiya Sachin-chaurasiya merged commit f6ecc41 into main Jan 28, 2024
23 of 25 checks passed
@Sachin-chaurasiya Sachin-chaurasiya deleted the issue-11944-v1 branch January 28, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaileshParmar11 ShaileshParmar11 ShaileshParmar11 approved these changes

@Sachin-chaurasiya Sachin-chaurasiya Sachin-chaurasiya approved these changes

@karanh37 karanh37 Awaiting requested review from karanh37

@chirag-madlani chirag-madlani Awaiting requested review from chirag-madlani

Assignees

@harshach harshach

@Ashish8689 Ashish8689

Labels
backend e2e This will trigger e2e test workflows safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Backend - API support to fetch count for mentions
4 participants
@harshach @Sachin-chaurasiya @ShaileshParmar11 @Ashish8689