Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: add Content-type for patch request in request interceptor #14879

Merged
merged 5 commits into from
Jan 26, 2024
Merged

Minor: add Content-type for patch request in request interceptor #14879

merged 5 commits into from
Jan 26, 2024

Conversation

Sachin-chaurasiya
Copy link
Member

@Sachin-chaurasiya Sachin-chaurasiya commented Jan 25, 2024 •
edited
Loading

Describe your changes:

I worked on removing the redundant header config for patch requests and added the config in the request interceptor

Screen.Recording.2024-01-26.at.7.32.52.PM.mov

Type of change:

  • Improvement

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Sachin-chaurasiya Sachin-chaurasiya self-assigned this Jan 25, 2024
@github-actions github-actions bot added the UI UI specific issues label Jan 25, 2024
@Sachin-chaurasiya Sachin-chaurasiya added enhancement New feature or request and removed UI UI specific issues labels Jan 25, 2024
@github-actions github-actions bot added safe to test Add this label to run secure Github workflows on PRs UI UI specific issues labels Jan 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 25, 2024 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 52%
 52.99% (27296/51515) 35.1% (10875/30987) 33.9% (3195/9426)

@Sachin-chaurasiya Sachin-chaurasiya added the e2e This will trigger e2e test workflows label Jan 26, 2024
karanh37
karanh37 previously approved these changes Jan 26, 2024
View reviewed changes
@Sachin-chaurasiya Sachin-chaurasiya marked this pull request as ready for review January 26, 2024 14:49
@cypress Cypress
Copy link

cypress bot commented Jan 26, 2024 •
edited
Loading

10 failed tests on run #33073 ↗︎

10 673 25 0 Flakiness 0

Details:

Fix importGlossaryInCSVFormat content-type header
Project: openmetadata Commit: e782cc4019
Status: Failed Duration: 37:09 💡
Started: Jan 26, 2024 5:53 PM Ended: Jan 26, 2024 6:30 PM
Failed  Pages/Glossary.spec.js • 1 failed test • cypress-ci-psql-oss-7671443433-1

View Output Video

Test Artifacts
Glossary page should work properly > Update glossary term Screenshots Video
Failed  Pages/Permission.spec.ts • 3 failed tests • cypress-ci-psql-oss-7671443433-1

View Output Video

Test Artifacts
Permissions > check ViewBasic, ViewSampleData & ViewQueries permission Screenshots Video
Permissions > check ViewBasic, ViewSampleData, ViewQueries & ViewTests permission Screenshots Video
Permissions > check EditDisplayName permission Screenshots Video
Failed  Pages/SearchIndexDetails.spec.js • 2 failed tests • cypress-ci-psql-oss-7671443433-1

View Output Video

Test Artifacts
SearchIndexDetails page should work properly for data consumer role > All permissible actions on search index details page should work properly Screenshots Video
SearchIndexDetails page should work properly for data steward role > All permissible actions on search index details page should work properly Screenshots Video
Failed  Features/RecentlyViewed.spec.js • 1 failed test • cypress-ci-psql-oss-7671443433-1

View Output Video

Test Artifacts
Recently viwed data assets > recently view section should have at max list of 5 entity Screenshots Video
Failed  Pages/Login.spec.js • 1 failed test • cypress-ci-psql-oss-7671443433-1

View Output Video

Test Artifacts
Login flow should work properly > Signin using invalid credentials Screenshots Video

The first 5 failed specs are shown, see all 6 specs in Cypress Cloud.

Review all test suite changes for PR #14879 ↗︎

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Sachin-chaurasiya Sachin-chaurasiya merged commit c7e6619 into main Jan 26, 2024
14 of 20 checks passed
@Sachin-chaurasiya Sachin-chaurasiya deleted the improve-patch-headers-config-part branch January 26, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karanh37 karanh37 karanh37 left review comments

@harshach harshach Awaiting requested review from harshach

@chirag-madlani chirag-madlani Awaiting requested review from chirag-madlani

Assignees

@Sachin-chaurasiya Sachin-chaurasiya

Labels
e2e This will trigger e2e test workflows enhancement New feature or request safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sachin-chaurasiya @chirag-madlani @karanh37