Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE-14881: PinotDB Test Connection Success #14882

Merged
merged 4 commits into from
Feb 13, 2024

Conversation

Supan90-Shah3006
Copy link
Contributor

Describe your changes:

Fixes #14881

I refered PinotDB docs for this issue. There is a problem with PinotDB Broker Host & Pinot Controller Host. So i swap this two host & port because it is mentioned in this docs.

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

Copy link
Collaborator

@pmbrull pmbrull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Thanks for the help on the docs. Re the code change, have a small questions

@pmbrull pmbrull added the safe to test Add this label to run secure Github workflows on PRs label Jan 26, 2024
Copy link
Contributor

github-actions bot commented Jan 26, 2024

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 60%
61.24% (31249/51031) 40.36% (12468/30890) 40.7% (3841/9438)

Copy link
Collaborator

@pmbrull pmbrull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted the code change and kept the docs update. Thanks

Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@pmbrull pmbrull merged commit 4915d68 into open-metadata:main Feb 13, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Ingestion safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PinotDB Test Connection Failed
2 participants