Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: support testCase data in entity card popover and fix cypress #14887

Merged
merged 3 commits into from
Jan 26, 2024
Merged

MINOR: support testCase data in entity card popover and fix cypress #14887

merged 3 commits into from
Jan 26, 2024

Conversation

Ashish8689
Copy link
Contributor

Describe your changes:

  • support test case data in entity popover card
  • fix activity feed and task cypress failure
image
Screen.Recording.2024-01-26.at.12.55.53.PM.mov

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Ashish8689 Ashish8689 added the UI UI specific issues label Jan 26, 2024
@Ashish8689 Ashish8689 self-assigned this Jan 26, 2024
@github-actions github-actions bot added the safe to test Add this label to run secure Github workflows on PRs label Jan 26, 2024
@Ashish8689 Ashish8689 added the e2e This will trigger e2e test workflows label Jan 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 52%
 52.84% (27173/51423) 35.23% (10845/30786) 33.82% (3183/9412)

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@cypress Cypress
Copy link

cypress bot commented Jan 26, 2024

1 failed test on run #33062 ↗︎

1 663 25 0 Flakiness 0

Details:

minor changes
Project: openmetadata Commit: e8ec81d2d1
Status: Failed Duration: 36:56 💡
Started: Jan 26, 2024 8:02 AM Ended: Jan 26, 2024 8:39 AM
Failed  cypress/e2e/Pages/GlossaryVersionPage.spec.js • 1 failed test • cypress-ci-psql-oss-7665292010-1

View Output Video

Test Artifacts
Glossary and glossary term version pages should work properly > Glossary term version page should display owner and reviewer changes properly Screenshots Video

Review all test suite changes for PR #14887 ↗︎

@Sachin-chaurasiya Sachin-chaurasiya merged commit f1c76ab into main Jan 26, 2024
21 of 27 checks passed
@Sachin-chaurasiya Sachin-chaurasiya deleted the test-case-popover branch January 26, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sachin-chaurasiya Sachin-chaurasiya Sachin-chaurasiya approved these changes

@ShaileshParmar11 ShaileshParmar11 ShaileshParmar11 approved these changes

@harshach harshach Awaiting requested review from harshach

@karanh37 karanh37 Awaiting requested review from karanh37

@chirag-madlani chirag-madlani Awaiting requested review from chirag-madlani

Assignees

@Ashish8689 Ashish8689

Labels
e2e This will trigger e2e test workflows safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ashish8689 @Sachin-chaurasiya @ShaileshParmar11