Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Display Name for Alerts #14889

Merged
merged 2 commits into from
Jan 26, 2024
Merged

Fix Display Name for Alerts #14889

merged 2 commits into from
Jan 26, 2024

Conversation

mohityadav766
Copy link
Contributor

Describe your changes:

  • This PR fixes Display Name for alerts and notifications.
  • Also fixed error condition in filtering for general metadata events

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@mohityadav766 mohityadav766 added backend safe to test Add this label to run secure Github workflows on PRs labels Jan 26, 2024
@mohityadav766 mohityadav766 self-assigned this Jan 26, 2024
@mohityadav766 mohityadav766 requested a review from a team as a code owner January 26, 2024 09:17
@mohityadav766 mohityadav766 merged commit 3f234df into main Jan 26, 2024
21 of 22 checks passed
@mohityadav766 mohityadav766 deleted the fixesForAlerts branch January 26, 2024 09:20
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aniketkatkar97 aniketkatkar97 aniketkatkar97 approved these changes

Assignees

@mohityadav766 mohityadav766

Labels
backend safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mohityadav766 @aniketkatkar97