Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: Add cypress tests for data observability and notification alerts #14900

Merged
merged 5 commits into from
Jan 28, 2024
Merged

Minor: Add cypress tests for data observability and notification alerts #14900

merged 5 commits into from
Jan 28, 2024

Conversation

aniketkatkar97
Copy link
Member

I worked on adding cypress tests for

  • Notification alert CRUD flow
  • Observability alert CRUD flow

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@aniketkatkar97 aniketkatkar97 requested a review from a team January 28, 2024 12:38
@aniketkatkar97 aniketkatkar97 self-assigned this Jan 28, 2024
@github-actions github-actions bot added UI UI specific issues safe to test Add this label to run secure Github workflows on PRs labels Jan 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 53%
 53.24% (27299/51274) 35.21% (10876/30887) 34.03% (3195/9388)

@aniketkatkar97 aniketkatkar97 added the e2e This will trigger e2e test workflows label Jan 28, 2024
@aniketkatkar97 aniketkatkar97 marked this pull request as ready for review January 28, 2024 14:07
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
0.0% Coverage on New Code
21.0% Duplication on New Code

See analysis details on SonarCloud

@cypress Cypress
Copy link

cypress bot commented Jan 28, 2024

8 failed tests on run #33079 ↗︎

8 683 12 0 Flakiness 0

Details:

add cypress tests for observability alert CRUD flow
Project: openmetadata Commit: 71b07a5a11
Status: Failed Duration: 38:19 💡
Started: Jan 28, 2024 2:25 PM Ended: Jan 28, 2024 3:03 PM
Failed  NotificationAlerts.spec.js • 4 failed tests • cypress-ci-psql-oss-7686283147-1

View Output Video

Test Artifacts
Notification Alert Flow > Create new alert Screenshots Video
Notification Alert Flow > Alert details page Screenshots Video
Notification Alert Flow > Edit created alert Screenshots Video
Notification Alert Flow > Delete created alert Screenshots Video
Failed  ObservabilityAlerts.spec.js • 4 failed tests • cypress-ci-psql-oss-7686283147-1

View Output Video

Test Artifacts
Observability Alert Flow > Create new alert Screenshots Video
Observability Alert Flow > Alert details page Screenshots Video
Observability Alert Flow > Edit created alert Screenshots Video
Observability Alert Flow > Delete created alert Screenshots Video

Review all test suite changes for PR #14900 ↗︎

@harshach harshach merged commit 5f1069b into main Jan 28, 2024
21 of 32 checks passed
@harshach harshach deleted the observability-cypress branch January 28, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshach harshach Awaiting requested review from harshach

@karanh37 karanh37 Awaiting requested review from karanh37

@chirag-madlani chirag-madlani Awaiting requested review from chirag-madlani

@Sachin-chaurasiya Sachin-chaurasiya Awaiting requested review from Sachin-chaurasiya

Assignees

@aniketkatkar97 aniketkatkar97

Labels
e2e This will trigger e2e test workflows safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aniketkatkar97 @harshach