Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: fix activity feed persisting old data even if new activity is performed in entity page #14901

Merged
merged 1 commit into from
Jan 28, 2024

Conversation

Ashish8689
Copy link
Contributor

Describe your changes:

  • I worked on fixing the activity feed persisting old data, even if new activity is performed in entity page

Issue :

Screen.Recording.2024-01-28.at.7.59.43.PM.mov

Resolved :

Screen.Recording.2024-01-28.at.7.58.17.PM.mov

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Ashish8689 Ashish8689 added the UI UI specific issues label Jan 28, 2024
@Ashish8689 Ashish8689 self-assigned this Jan 28, 2024
@github-actions github-actions bot added the safe to test Add this label to run secure Github workflows on PRs label Jan 28, 2024
Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 53%
53.24% (27296/51272) 35.2% (10876/30896) 34.04% (3195/9385)

Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

cypress bot commented Jan 28, 2024

2 failed tests on run #33080 ↗︎

2 681 25 0 Flakiness 0

Details:

fix activity feed updated data on tab change after some new activity
Project: openmetadata Commit: 420e8b5f8c
Status: Failed Duration: 35:58 💡
Started: Jan 28, 2024 3:39 PM Ended: Jan 28, 2024 4:15 PM
Failed  cypress/e2e/Pages/Users.spec.ts • 2 failed tests • cypress-ci-psql-oss-7686687517-1

View Output Video

Test Artifacts
User with different Roles > Admin Soft delete user Screenshots Video
User with different Roles > Admin Restore soft deleted user Screenshots Video

Review all test suite changes for PR #14901 ↗︎

@harshach harshach merged commit 0b840b4 into main Jan 28, 2024
28 of 42 checks passed
@harshach harshach deleted the activity-feed-refresh branch January 28, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e This will trigger e2e test workflows safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants