Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: Fix observability cypress tests #14907

Merged
merged 4 commits into from
Jan 29, 2024
Merged

Minor: Fix observability cypress tests #14907

merged 4 commits into from
Jan 29, 2024

Conversation

aniketkatkar97
Copy link
Member

Describe your changes:

Fixes

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@aniketkatkar97 aniketkatkar97 added the e2e This will trigger e2e test workflows label Jan 29, 2024
@aniketkatkar97 aniketkatkar97 self-assigned this Jan 29, 2024
@aniketkatkar97 aniketkatkar97 changed the title Minor: Fix observability cypress tests Minor[WIP]: Fix observability cypress tests Jan 29, 2024
@github-actions github-actions bot added UI UI specific issues safe to test Add this label to run secure Github workflows on PRs labels Jan 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 53%
 53.23% (27301/51292) 35.21% (10877/30896) 34.02% (3195/9391)

@cypress Cypress
Copy link

cypress bot commented Jan 29, 2024 •
edited
Loading

Passing run #33084 ↗︎

0 691 12 0 Flakiness 0

Details:

Merge branch 'main' into fix-alert-cypress
Project: openmetadata Commit: 421248a4f9
Status: Passed Duration: 38:15 💡
Started: Jan 29, 2024 5:53 AM Ended: Jan 29, 2024 6:31 AM

Review all test suite changes for PR #14907 ↗︎

@aniketkatkar97 aniketkatkar97 marked this pull request as draft January 29, 2024 04:49
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@aniketkatkar97 aniketkatkar97 marked this pull request as ready for review January 29, 2024 05:34
@aniketkatkar97 aniketkatkar97 requested a review from a team as a code owner January 29, 2024 05:34
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@mohityadav766 mohityadav766 merged commit 8afde3e into main Jan 29, 2024
19 of 20 checks passed
@mohityadav766 mohityadav766 deleted the fix-alert-cypress branch January 29, 2024 07:01
@aniketkatkar97 aniketkatkar97 changed the title Minor[WIP]: Fix observability cypress tests Minor: Fix observability cypress tests Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshach harshach Awaiting requested review from harshach

@karanh37 karanh37 Awaiting requested review from karanh37

@chirag-madlani chirag-madlani Awaiting requested review from chirag-madlani

@Sachin-chaurasiya Sachin-chaurasiya Awaiting requested review from Sachin-chaurasiya

Assignees

@aniketkatkar97 aniketkatkar97

Labels
backend e2e This will trigger e2e test workflows safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aniketkatkar97 @mohityadav766