Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: redirect to home page for signin route when user is already logged in #14915

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

ShaileshParmar11
Copy link
Contributor

@ShaileshParmar11 ShaileshParmar11 commented Jan 29, 2024

Describe your changes:

redirect to home page for sign in route when user is already logged in

Screen.Recording.2024-01-29.at.11.43.07.AM.mov

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added the UI UI specific issues label Jan 29, 2024
@ShaileshParmar11 ShaileshParmar11 changed the title Minor: redirect to home page for signin route when used is already logged in Minor: redirect to home page for signin route when user is already logged in Jan 29, 2024
@github-actions github-actions bot added the safe to test Add this label to run secure Github workflows on PRs label Jan 29, 2024
@ShaileshParmar11 ShaileshParmar11 self-assigned this Jan 29, 2024
Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 53%
53.23% (27301/51292) 35.21% (10877/30896) 34.02% (3195/9391)

Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ShaileshParmar11 ShaileshParmar11 enabled auto-merge (squash) January 29, 2024 10:30
@ShaileshParmar11 ShaileshParmar11 merged commit 09b5bcc into main Jan 29, 2024
14 of 16 checks passed
@ShaileshParmar11 ShaileshParmar11 deleted the signin-page-redirection branch January 29, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants